Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RF] Implement RooFit::DataError() pythonization in C++ #17092

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

guitargeek
Copy link
Contributor

This reduces divergence between the Python and C++ interface.

Tested by the tutorials where this string-to-enum pythonization is used.

Copy link

github-actions bot commented Nov 28, 2024

Test Results

    19 files      19 suites   4d 4h 34m 16s ⏱️
 2 725 tests  2 723 ✅ 1 💤 1 ❌
49 142 runs  49 141 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit b36dc4f.

♻️ This comment has been updated with latest results.

This reduces divergence between the Python and C++ interface.

Tested by the tutorials where this string-to-enum pythonization is used.
@guitargeek
Copy link
Contributor Author

Failure on mac14 unrelated:

 1280:tutorial-dataframe-distrdf002_dask_connection-py

Copy link
Contributor

@aaronj0 aaronj0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@guitargeek guitargeek merged commit 840f3dd into root-project:master Dec 2, 2024
19 of 22 checks passed
@guitargeek guitargeek deleted the data_error branch December 2, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants