return missing headers when raising HeaderRowNotFoundError #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chopraanmol1
requested changes
Sep 27, 2018
|
@chopraanmol1 Thanks for the review, added this test-case and discovered that the previous code didn't worked when query was composed of multiple regexes. Fixed that now. |
chopraanmol1
requested changes
Sep 28, 2018
lib/roo/base.rb
Outdated
| end | ||
| end | ||
| raise Roo::HeaderRowNotFoundError | ||
| missing_headers = query.each_with_object([]) \ |
There was a problem hiding this comment.
what about using query.select{...} or query.reject{...} instead
There was a problem hiding this comment.
agree, select is prettier
spec/lib/roo/base_spec.rb
Outdated
|
|
||
| it 'returns missing headers' do | ||
| expect { spreadsheet.row_with([/Header/, /Missing Header 1/, /Missing Header 2/]) }.to \ | ||
| raise_error(Roo::HeaderRowNotFoundError, /Missing Header 1|Missing Header 2/) |
There was a problem hiding this comment.
/Missing Header 1|Missing Header 2/ only ensures that one of missing header is part of exception.
If I change the code to raise just missing_headers.first this test case will still pass. I think this regex should ensure that all missing header/query is part of exception.
There was a problem hiding this comment.
agree, changed that!
spec/lib/roo/base_spec.rb
Outdated
| @@ -154,9 +154,14 @@ def sheets | |||
| end | |||
|
|
|||
| context 'without a matching header row' do | |||
| it 'raises an error' do | |||
| it 'raises an error ' do | |||
There was a problem hiding this comment.
'raises an error ' -> 'raises an error'
chopraanmol1
requested changes
Sep 28, 2018
spec/lib/roo/base_spec.rb
Outdated
|
|
||
| it 'returns missing headers' do | ||
| expect { spreadsheet.row_with([/Header/, /Missing Header 1/, /Missing Header 2/]) }.to \ | ||
| raise_error(Roo::HeaderRowNotFoundError, /(?=.*Missing Header 1)(?=.*Missing Header 2)/) |
There was a problem hiding this comment.
This test will pass even if I raise query instead of missing_headers
There was a problem hiding this comment.
Totally true, decided to check for returned string, improves readability imho
chopraanmol1
approved these changes
Sep 28, 2018
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Jan 20, 2019
pkgsrc change: add "USE_LANGUAGES= # none". ## [2.8.0] 2019-01-18 ### Fixed - Fixed inconsistent column length for CSV [375](roo-rb/roo#375) - Fixed formatted_value with `%` for Excelx [416](roo-rb/roo#416) - Improved Memory consumption and performance [434](roo-rb/roo#434) [449](roo-rb/roo#449) [454](roo-rb/roo#454) [456](roo-rb/roo#456) [458](roo-rb/roo#458) [462](roo-rb/roo#462) [466](roo-rb/roo#466) - Accept both Transitional and Strict Type for Excelx's worksheets [441](roo-rb/roo#441) - Fixed ruby warnings [442](roo-rb/roo#442) [476](roo-rb/roo#476) - Restore support for URL as file identifier for CSV [462](roo-rb/roo#462) - Fixed missing location for Excelx's links [482](roo-rb/roo#482) ### Changed / Added - Drop support for ruby 2.2.x and lower - Updated rubyzip version for fixing security issue. Now minimal version is 1.2.1 - Roo::Excelx::Coordinate now inherits Array [458](roo-rb/roo#458) - Improved Roo::HeaderRowNotFoundError exception's message [461](roo-rb/roo#461) - Added `empty_cell` option which by default disable allocation for Roo::Excelx::Cell::Empty [464](roo-rb/roo#464) - Added support for variable number of decimals for Excelx's formatted_value [387](roo-rb/roo#387) - Added `disable_html_injection` option to disable html injection for shared string in `Roo::Excelx` [392](roo-rb/roo#392) - Added image extraction for Excelx [414](roo-rb/roo#414) [397](roo-rb/roo#397) - Added support for `1e6` as scientific notation for Excelx [433](roo-rb/roo#433) - Added support for Integer as 0 based index for Excelx's `sheet_for` [455](roo-rb/roo#455) - Extended `no_hyperlinks` option for non streaming Excelx methods [459](roo-rb/roo#459) - Added `empty_cell` option to disable Roo::Excelx::Cell::Empty allocation for Excelx [464](roo-rb/roo#464) - Added support for Integer with leading zero for Roo:Excelx [479](roo-rb/roo#479) - Refactored Excelx code [453](roo-rb/roo#453) [477](roo-rb/roo#477) [483](roo-rb/roo#483) [484](roo-rb/roo#484) ### Deprecations - Roo::Excelx::Sheet#present_cells is deprecated [454](roo-rb/roo#454) - Roo::Utils.split_coordinate is deprecated [458](roo-rb/roo#458) - Roo::Excelx::Cell::Base#link is deprecated [457](roo-rb/roo#457)
aravindm
pushed a commit
to chobiwa/roo
that referenced
this pull request
Jun 18, 2019
return missing headers when raising HeaderRowNotFoundError
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
return missing headers when raising HeaderRowNotFoundError
fixes #412