Skip to content

chore: Improve look of hwlabel to better match manual#66

Closed
Holzhaus wants to merge 3 commits into
ronso0:controller-prefs-markupfrom
Holzhaus:controller-prefs-markup
Closed

chore: Improve look of hwlabel to better match manual#66
Holzhaus wants to merge 3 commits into
ronso0:controller-prefs-markupfrom
Holzhaus:controller-prefs-markup

Conversation

@Holzhaus
Copy link
Copy Markdown

@Holzhaus Holzhaus commented Apr 4, 2024

No description provided.

"font-size: 70%;"
"font-weight: 600;"
"line-height: 120%;"
"text-transform: uppercase;"
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't enforce that tbh.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd pick this commit right away, I'd only remove that line
Okay?.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't enforce that tbh.

I know we do that in the manual though.
In the end, let's keep it for consistency (instead of changing it in the manual, for each doc...)

@ronso0 ronso0 force-pushed the controller-prefs-markup branch from 35ed4cd to 81a4188 Compare April 4, 2024 19:18
@ronso0
Copy link
Copy Markdown
Owner

ronso0 commented Apr 4, 2024

I adopted this, thanks!

@ronso0 ronso0 closed this Apr 4, 2024
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 8559893580

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 62 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 31.084%

Files with Coverage Reduction New Missed Lines %
src/controllers/legacycontrollersettings.cpp 62 40.27%
Totals Coverage Status
Change from base Build 8560126788: 0.0%
Covered Lines: 31311
Relevant Lines: 100729

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants