Controller preferences: add :hwbtn: markup parser#13046
Merged
Conversation
Swiftb0y
reviewed
Apr 4, 2024
f021bd2 to
35ed4cd
Compare
Member
Member
Member
Author
|
Thanks for looking into it @Holzhaus I think we're good with the |
Member
Author
|
oh, you already have fix ... |
Co-authored-by: Swiftb0y <12380386+Swiftb0y@users.noreply.github.com> Co-authored-by: Jan Holthuis <jholthuis@mixxx.org>
35ed4cd to
81a4188
Compare
Member
No, just some minor improvement unfortunately 😢 |
Swiftb0y
approved these changes
Apr 5, 2024
Member
Swiftb0y
left a comment
There was a problem hiding this comment.
LGTM in terms of code. Can't comment much on the formatting because I don't know HTML&CSS well enough.
Member
|
LGTM! Thank you! |
Member
Author
|
Thanks everyone for the quick response! |
Member
|
Sorry I didn't have time test this - thanks for looking into this @ronso0 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Allows using :hwbtn:

LABELin xml and moves the styling to c++It's just bold now (dropped the
ttmonospace font tag).The only way I figured to get horizontal padding was to wrap the label in
Padding is not applied with
padding: 2px;alone. Might be one of those qss quirks where we need to set an unrelated property, though withspanneitherdisplay: inline-block;norbox-sizing: border-box;orborderwork@acolombier Mind taking a look?