core/state: correct account selfdestruct EIP-6780 (part of 7702) #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trantienduchn
force-pushed
the
eip-7702-p11
branch
from
c362d01 to
f2a7287
Compare
trantienduchn
changed the title
trantienduchn
force-pushed
the
eip-7702-p11
branch
from
f2a7287 to
51ae1d0
Compare
trantienduchn
changed the title
minh-bq
reviewed
Mar 26, 2025
This pull request fixes the broken feature where the entire storage set is overridden. Originally, the storage set override was achieved by marking the associated account as deleted, preventing access to the storage slot on disk. However, since #29520, this flag is also checked when accessing the account, rendering the account unreachable. A fix has been applied in this pull request, which re-creates a new state object with all account metadata inherited.
minh-bq
reviewed
Mar 26, 2025
minh-bq
approved these changes
Mar 26, 2025
Contributor
minh-bq
left a comment
minh-bq
left a comment
There was a problem hiding this comment.
With quick review, the PR LGTM.
Contributor
Author
|
Test Doable step: remove fakeStorage? Related PR: ethereum/go-ethereum#24916 |
sonhv0212
approved these changes
Mar 27, 2025
Closed
trantienduchn
added a commit
to trantienduchn/ronin
that referenced
this pull request
May 21, 2025
Member PRs: - ronin-chain#32 `core/types: setcode tx type` - ronin-chain#33 `core/types: transaction NewMessage() add authList` - ronin-chain#35 `core/vm: update 7702 EVM resolve code & gas estimation` - ronin-chain#38 `core: state_transition with AuthList` - ronin-chain#41 `internal, graphql, test: remaining components of 7702` - ronin-chain#46 `all: refactor names & singner 7702` - ronin-chain#47 `core/types, test: correct chainId 7702` - ronin-chain#49 `core/txpool: support SetCode tx 7702` - ronin-chain#53 `core/state: correct account selfdestruct EIP-6780 (part of 7702)` - ronin-chain#55 `core/txpool/legacypool: reject gapped tx from delegated account` --------- Co-authored-by: sonhv0212 <[email protected]> Co-authored-by: Martin Holst Swende <[email protected]> Co-authored-by: Felix Lange <[email protected]> Co-authored-by: Shude Li <[email protected]> Co-authored-by: lightclient <[email protected]> Co-authored-by: Marius van der Wijden <[email protected]> Co-authored-by: rjl493456442 <[email protected]> Co-authored-by: buddho <[email protected]> Co-authored-by: rjl493456442 <[email protected]> Co-authored-by: rekyyang <[email protected]> Co-authored-by: sashabeton <[email protected]> Co-authored-by: sashabeton <[email protected]>
Merged
chiphamskymavis
pushed a commit
that referenced
this pull request
May 21, 2025
* pick up ethereum/go-ethereum#29520 * core/state: update test cases * core/state: fix SetStorage override behavior (#30185) This pull request fixes the broken feature where the entire storage set is overridden. Originally, the storage set override was achieved by marking the associated account as deleted, preventing access to the storage slot on disk. However, since #29520, this flag is also checked when accessing the account, rendering the account unreachable. A fix has been applied in this pull request, which re-creates a new state object with all account metadata inherited. * fixup! pick up ethereum/go-ethereum#29520 * fixup! core/state: fix SetStorage override behavior (#30185) --------- Co-authored-by: rjl493456442 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from: