core/types: transaction NewMessage() add authList #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trantienduchn
commented
Mar 13, 2025
| args.BlobFeeCap = new(hexutil.Big) | ||
| } | ||
| msg := types.NewMessage(addr, args.To, 0, value, gas, gasPrice, gasFeeCap, gasTipCap, data, accessList, true, (*big.Int)(args.BlobFeeCap), args.BlobHashes) | ||
| msg := types.NewMessage(addr, args.To, 0, value, gas, gasPrice, gasFeeCap, gasTipCap, data, accessList, true, (*big.Int)(args.BlobFeeCap), args.BlobHashes, args.AuthorizationList) |
| } | ||
|
|
||
| // TODO: pass authList as go-ethereum did, leave it to "tests" update tasks | ||
| // https://github.com/ethereum/go-ethereum/blob/aaaf01d71232d1b7da5ab2ae9258f7fb9f22b1bf/tests/state_test_util.go#L479 |
Contributor
Author
There was a problem hiding this comment.
this is complicated, need state_transition involvement, leave it to later PRs
trantienduchn
force-pushed
the
base-eip-7702-2
branch
from
aad4814 to
87b3f69
Compare
sonhv0212
reviewed
Mar 14, 2025
| true, | ||
| call.BlobGasFeeCap(), | ||
| call.BlobHashes(), | ||
| nil, |
Contributor
There was a problem hiding this comment.
This msg will be passed to core.ApplyMessage, so missing authList field will cause estimating gas failed
Contributor
Author
There was a problem hiding this comment.
hmm, this is big, but passing AuthList requires to update the core.Message interface => introduce more complexity to this PR. At the moment, it haven't broken any test yet and gas estimation is not implemented in state_transistion. So update it together with state_transition?
minh-bq
approved these changes
Mar 17, 2025
Adapt callers
trantienduchn
force-pushed
the
base-eip-7702-2
branch
from
87b3f69 to
3ec7559
Compare
sonhv0212
approved these changes
Mar 17, 2025
minh-bq
approved these changes
Mar 17, 2025
Closed
trantienduchn
added a commit
to trantienduchn/ronin
that referenced
this pull request
May 21, 2025
Member PRs: - ronin-chain#32 `core/types: setcode tx type` - ronin-chain#33 `core/types: transaction NewMessage() add authList` - ronin-chain#35 `core/vm: update 7702 EVM resolve code & gas estimation` - ronin-chain#38 `core: state_transition with AuthList` - ronin-chain#41 `internal, graphql, test: remaining components of 7702` - ronin-chain#46 `all: refactor names & singner 7702` - ronin-chain#47 `core/types, test: correct chainId 7702` - ronin-chain#49 `core/txpool: support SetCode tx 7702` - ronin-chain#53 `core/state: correct account selfdestruct EIP-6780 (part of 7702)` - ronin-chain#55 `core/txpool/legacypool: reject gapped tx from delegated account` --------- Co-authored-by: sonhv0212 <[email protected]> Co-authored-by: Martin Holst Swende <[email protected]> Co-authored-by: Felix Lange <[email protected]> Co-authored-by: Shude Li <[email protected]> Co-authored-by: lightclient <[email protected]> Co-authored-by: Marius van der Wijden <[email protected]> Co-authored-by: rjl493456442 <[email protected]> Co-authored-by: buddho <[email protected]> Co-authored-by: rjl493456442 <[email protected]> Co-authored-by: rekyyang <[email protected]> Co-authored-by: sashabeton <[email protected]> Co-authored-by: sashabeton <[email protected]>
Merged
chiphamskymavis
pushed a commit
that referenced
this pull request
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
core/types from ethereum/go-ethereum#30078