Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

fix(rome_cli): correctly compute can_handle in CI mode #3500

Merged
merged 2 commits into from
Oct 26, 2022

Conversation

ematipico
Copy link
Contributor

Summary

Closes #3495

Test Plan

Added a new test case

@ematipico ematipico requested a review from leops as a code owner October 26, 2022 12:28
@netlify
Copy link

netlify bot commented Oct 26, 2022

Deploy Preview for rometools canceled.

Name Link
🔨 Latest commit adbab4a
🔍 Latest deploy log https://app.netlify.com/sites/rometools/deploys/6359331f8525820009fc3525

@ematipico ematipico temporarily deployed to netlify-playground October 26, 2022 12:28 Inactive
@@ -0,0 +1,46 @@
---
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test is correct because if the formatter was enabled, it would have added ; at the end of the statement

@github-actions
Copy link

github-actions bot commented Oct 26, 2022

crates/rome_cli/src/traversal.rs Outdated Show resolved Hide resolved
crates/rome_cli/src/traversal.rs Outdated Show resolved Hide resolved
crates/rome_cli/src/traversal.rs Outdated Show resolved Hide resolved
@ematipico ematipico temporarily deployed to netlify-playground October 26, 2022 13:16 Inactive
@ematipico ematipico requested a review from leops October 26, 2022 13:16
@ematipico ematipico merged commit f14d91c into main Oct 26, 2022
@ematipico ematipico deleted the fix/ci-can-handle branch October 26, 2022 13:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 formatter.enabled = false breaks the linter with rome ci .
2 participants