Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

🐛 formatter.enabled = false breaks the linter with rome ci . #3495

Closed
1 task done
nstepien opened this issue Oct 26, 2022 · 3 comments · Fixed by #3500
Closed
1 task done

🐛 formatter.enabled = false breaks the linter with rome ci . #3495

nstepien opened this issue Oct 26, 2022 · 3 comments · Fixed by #3500
Assignees
Labels
A-CLI Area: CLI S-Bug: confirmed Status: report has been confirmed as a valid bug S-Planned Status: planned by the team, but not in the short term
Milestone

Comments

@nstepien
Copy link
Contributor

Environment information

OS: win11, 64bit
Installation method: `npm i -D [email protected]`

What happened?

  1. Install [email protected]
  2. Have the formatter disabled
  3. run rome ci .

Expected result

Rome should run the linter, instead nothing happens:

Checked 0 files in 4ms

Adding an explicit

  "linter": {
    "enabled": true,

doesn't help.

I believe this doesn't happen with 0.10.1-next, might be a recent regression.

Code of Conduct

  • I agree to follow Rome's Code of Conduct
@nstepien nstepien added the S-To triage Status: user report of a possible bug that needs to be triaged label Oct 26, 2022
@ematipico
Copy link
Contributor

ematipico commented Oct 26, 2022

I think the issue might be the dot . in the command rome ci command. Could you try by speechifying the folder instead?

I believe it's an issue of each command that traverses the file system. Meaning that commands that contain . or ./ won't work.

@ematipico ematipico added S-Bug: confirmed Status: report has been confirmed as a valid bug A-CLI Area: CLI S-Planned Status: planned by the team, but not in the short term and removed S-To triage Status: user report of a possible bug that needs to be triaged labels Oct 26, 2022
@ematipico ematipico added this to the 10.0.0 milestone Oct 26, 2022
@nstepien
Copy link
Contributor Author

I tried

npx rome ci D:\repos\my-repo\

and that didn't work either.
FWIW if I remove "enabled": false, from the formatter config then it does work fine, with the dot.

@ematipico
Copy link
Contributor

I could reproduce the issue, thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-CLI Area: CLI S-Bug: confirmed Status: report has been confirmed as a valid bug S-Planned Status: planned by the team, but not in the short term
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants