Support options with string keys#60
Closed
daniel-g wants to merge 6 commits intoroidrage:v0.2.x-stablefrom
daniel-g:v0.2.x-stable
Closed
Support options with string keys#60daniel-g wants to merge 6 commits intoroidrage:v0.2.x-stablefrom daniel-g:v0.2.x-stable
daniel-g wants to merge 6 commits intoroidrage:v0.2.x-stablefrom
daniel-g:v0.2.x-stable
Conversation
Collaborator
|
Hey @daniel-g, sorry for the long delay 😸. Can you accomplish this at the level just outside of passing the loaded hash to the session config? Adding an ActiveSupport dependency is non-trivial, imho. |
| - ree | ||
| - 1.9.3 | ||
| - 2.0.0 | ||
| - 1.8.7 |
Author
|
@meatballhat is this still valid to merge? |
Collaborator
|
@daniel-g ahoy! Thank you for backing out the ActiveSupport dependency. I understand the convenience of having this library handle hash key symbolizing, but I still prefer that you do this prior to passing arguments. |
Author
|
Yeah, I understood that when I reviewed it again :) |
Author
|
Closed in favor of #102 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I load session options in a YAML, so I need to accept strings also as keys.