Skip to content

deps(nuget): Bump Microsoft.NET.Test.Sdk from 18.3.0 to 18.5.1#723

Closed
dependabot[bot] wants to merge 1 commit intomainfrom
dependabot/nuget/testing-92e0d09f4d
Closed

deps(nuget): Bump Microsoft.NET.Test.Sdk from 18.3.0 to 18.5.1#723
dependabot[bot] wants to merge 1 commit intomainfrom
dependabot/nuget/testing-92e0d09f4d

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot Bot commented on behalf of github Apr 13, 2026

Pinned Microsoft.NET.Test.Sdk at 18.5.1.

Release notes

Sourced from Microsoft.NET.Test.Sdk's releases.

18.5.1

What's Changed

Full Changelog: microsoft/vstest@v18.5.0...v18.5.1

18.5.0

⚠️ Unlisted on Nuget, because of #​15718

What's Changed

Full Changelog: microsoft/vstest@v18.4.0...v18.5.0

18.4.0

What's Changed

New Contributors

Full Changelog: microsoft/vstest@v18.3.0...v18.4.0

Commits viewable in compare view.

@dependabot @github
Copy link
Copy Markdown
Contributor Author

dependabot Bot commented on behalf of github Apr 13, 2026

Labels

The following labels could not be found: nuget. Please create it before Dependabot can add it to a pull request.

Please fix the above issues or remove invalid values from dependabot.yml.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 13, 2026

🔍 Copilot Code Review — Six-Lens Analysis

Build Tests

⚠️ REQUEST CHANGES — 3 warning(s) and 0 info item(s) should be addressed.

📋 Summary

Metric Value
Files reviewed 4
🔴 Critical 0
🟡 Warning 3
🔵 Info 0
Build errors 1
Tests passed 4399 / 4399
📁 Changed files (4)
  • src/Meridian.Wpf/ViewModels/ActivityLogViewModel.cs
  • src/Meridian.Wpf/ViewModels/TradingHoursViewModel.cs
  • src/Meridian.Wpf/Views/ActivityLogPage.xaml.cs
  • tests/Meridian.Wpf.Tests/ViewModels/ActivityLogViewModelTests.cs

⚡ Real-Time Performance

  • [P-WARNING] Meridian.Wpf/ViewModels/ActivityLogViewModel.cs: Reflection-based JSON serialization — use source-generated JsonSerializerContext (ADR-014).

🛡️ Error Handling & Resilience

  • [E-WARNING] Meridian.Wpf/ViewModels/ActivityLogViewModel.cs: Bare catch (Exception) — use specific types from Core/Exceptions/ (e.g. DataProviderException, StorageException).
  • [E-WARNING] Meridian.Wpf/Views/ActivityLogPage.xaml.cs: Bare catch (Exception) — use specific types from Core/Exceptions/ (e.g. DataProviderException, StorageException).

ℹ️ About this review

This review applies the six-lens framework from code-review-agent.md:

  1. 🏗️ MVVM Architecture — thin code-behind, BindableBase, dependency rules
  2. Real-Time Performance — blocking calls, hot-path allocations, channel policies, ADR-014 JSON
  3. 🛡️ Error Handling & Resilience — exception hierarchy, provider reconnection, shutdown paths
  4. 🧪 Test Quality — naming convention, async patterns, no sleep/delay
  5. 🔌 Provider Compliance — interface completeness, rate limiting, [ImplementsAdr] attributes
  6. 📐 Conventions — structured logging, IHttpClientFactory, sealed classes, ADRs

Severity scale: 🔴 CRITICAL (must fix before merge) · 🟡 WARNING (should address) · 🔵 INFO (minor)

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Six-Lens Code Review — 0 critical issue(s) detected. See the detailed comment above for all findings.

@dependabot dependabot Bot changed the title deps(nuget): Bump the testing group with 1 update deps(nuget): Bump Microsoft.NET.Test.Sdk from 18.3.0 to 18.4.0 Apr 20, 2026
@dependabot dependabot Bot force-pushed the dependabot/nuget/testing-92e0d09f4d branch from c1ac575 to b1ce691 Compare April 20, 2026 06:40
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Six-Lens Code Review — 0 critical issue(s) detected. See the detailed comment above for all findings.

@dependabot dependabot Bot force-pushed the dependabot/nuget/testing-92e0d09f4d branch from b1ce691 to 03dad87 Compare April 21, 2026 22:32
---
updated-dependencies:
- dependency-name: Microsoft.NET.Test.Sdk
  dependency-version: 18.4.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: testing
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot force-pushed the dependabot/nuget/testing-92e0d09f4d branch from 03dad87 to 0dc72b4 Compare April 27, 2026 06:58
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Six-Lens Code Review — 3 warning(s) and 0 info item(s). See the detailed comment above for full findings.

@dependabot @github
Copy link
Copy Markdown
Contributor Author

dependabot Bot commented on behalf of github Apr 28, 2026

Looks like Microsoft.NET.Test.Sdk is updatable in another way, so this is no longer needed.

@dependabot dependabot Bot closed this Apr 28, 2026
@dependabot dependabot Bot changed the title deps(nuget): Bump Microsoft.NET.Test.Sdk from 18.3.0 to 18.4.0 deps(nuget): Bump Microsoft.NET.Test.Sdk from 18.3.0 to 18.5.1 Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants