Skip to content

Port verify-binding-redirects.ps1 to rel/18.5#15719

Merged
nohwnd merged 1 commit intomicrosoft:rel/18.5from
nohwnd:port-binding-redirect-rel-18.5
Apr 23, 2026
Merged

Port verify-binding-redirects.ps1 to rel/18.5#15719
nohwnd merged 1 commit intomicrosoft:rel/18.5from
nohwnd:port-binding-redirect-rel-18.5

Conversation

@nohwnd
Copy link
Copy Markdown
Member

@nohwnd nohwnd commented Apr 22, 2026

Ports the binding redirect verification script (and its wiring from �erify-nupkgs.ps1) from main/rel/18.7 to rel/18.5, so we can validate on this branch that the newVersion in each binding redirect actually matches the shipped assembly.

The script runs against the extracted Microsoft.TestPlatform.*.nupkg layout produced by verify-nupkgs.ps1. For each of vstest.console.exe, testhost.x86.exe, and datacollector.exe it:

  • finds the exe in the packaged layout
  • follows <probing privatePath> from the app.config
  • for every <dependentAssembly> reads the shipped DLL version
  • compares it to the redirect's newVersion

In CI it fails with the list of mismatches plus fix instructions. Locally it auto-updates the source app.config files (preserving whitespace and BOM) so you can just commit the result.

Ran cleanly on rel/18.5 HEAD (v18.5.0) against a Debug build — everything green, including System.Collections.Immutable 9.0.0.0 which was the one we wanted to verify.

Ports the binding redirect verification script (and verify-nupkgs.ps1 wiring)
from main/rel/18.7. Running against the shipped Microsoft.TestPlatform.*.nupkg
layout, the script validates that the newVersion of each assembly binding
redirect in vstest.console, testhost.x86, and datacollector app.config files
matches the actual assembly version of the DLL shipped next to the exe.

In CI it fails with instructions; locally it auto-fixes the app.config files.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@nohwnd nohwnd enabled auto-merge (squash) April 22, 2026 21:04
@nohwnd
Copy link
Copy Markdown
Member Author

nohwnd commented Apr 23, 2026

Flaky on ccparallel.

@nohwnd nohwnd disabled auto-merge April 23, 2026 05:51
@nohwnd nohwnd merged commit f2044ac into microsoft:rel/18.5 Apr 23, 2026
3 of 5 checks passed
This was referenced Apr 28, 2026
This was referenced Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant