expand on the have_.*_sample riff
#246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- create the `have...sample_matching` predicates which allow to match the samples against a predicate, for instance because one is looking for an (asynchronous) state change - create `have_new_samples` and `have_new_samples_matching` predicates to read more than one sample
g-arjones
approved these changes
May 11, 2020
|
Cool... Thanks for this 👍 |
….().matching
This is a lot more syskit-ish, and reads better
~~~
have_one_new_sample_matching(reader) { ... }
~~~
reads like we're matching reader, while
~~~
have_one_new_sample(reader).matching { ... }
~~~
reads better (admittedly in the narrow space of Syskit syntax ...)
It seems that rubocop 0.83 started to pick up .simplecov
doudou
force-pushed
the
expand_the_have_sample_predicates
branch
from
94b480d
to
f864bc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
test: improve the ability to reuse expectations tools-roby#164
create the
.matchingrefinement to the predicates, allowing to filterthe samples against a predicate, for instance because one is looking
for an (asynchronous) state change
create
have_new_samplesto find more than one sample