Skip to content

Commit

Permalink
fix: do not close stdout before calling bundler-using processes
Browse files Browse the repository at this point in the history
It breaks it in some ways when loading the gemspec files
  • Loading branch information
doudou committed Dec 4, 2024
1 parent 9065ae4 commit f83d9f2
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion lib/roby/app/rake.rb
Original file line number Diff line number Diff line change
Expand Up @@ -815,7 +815,8 @@ def self.define_rubocop_if_enabled(
end

def self.detect_rubocop?
run_rubocop("--version", out: :close)
# Do NOT use out: :close here, it breaks bundler in some ways
run_rubocop("--version", out: "/dev/null")
true
rescue Errno::ENOENT
false
Expand Down

0 comments on commit f83d9f2

Please sign in to comment.