Use Qt5 so change MOC to MOC5 #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@2maz Thanks, should be fixed by rock-core/base-cmake#89; if it is not, let me know. That's a bit of an oversight on my part. Edit: Also, the feature/qt5 branches are only left here so people using them don't trip over them being removed, before we have the combined build of qt4 and qt5 complete. I don't have time right now to look at the two remaining blockers for vizkit3d, but i am sure i can make some in the next few weeks. |
|
@pierrewillenbrockdfki thx for letting me know. Your fix works |
pierrewillenbrockdfki
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pierrewillenbrockdfki although you implemented some fallback mechanism, it did not work with base/types feature/qt5
Only a consistent use of MOC5 seems to work