Merged
Conversation
Fix History::load
* This commit allows keybinding for forcing accept line (even if validator fails). This is useful if you have a separate keybinding for accepting, such as `Alt-Enter`. It makes sense to show an error to user rather than insert an unexpected newline. * Forcing `Newline` is also accepted * `AcceptLine` meaning is changed (not it forces accept), but default `Enter` keybinding is not * `AcceptOrInsertLine` not has a flag that modifies it's behavior in the middle of the line (at the end it always submits, when validator returned false it's always a newline) * Fixed bug with exiting readline (both on success and error) when cursor is not on the last line
Fixes kkawakam#397, and perhaps kkawakam#413
…terrupt Handle SIGWINCH while calling move_cursor_at_leftmost
Update nix to 0.18
* Keep track of new entries in history If there is no new entry, we don't need to save. * Fix some links * Append history Breaking change: a mutable reference is now needed to save history * Trace history operations
We don't expect Meta-X in Vi insert mode only ANSI escape sequence. So Meta-X means Esc (exit insert mode) and do command associated to X.
…o-command-mode
…ck-to-command-mode Vi: insert mode escape seq fallback to command mode
Use only ::crate paths. And there is no need to redefine `hint` default implementation.
Hint display
Fixed error detection in move_cursor_at_leftmost
A tuple (instead of a struct) is used.
Update windows code
For example, you may have to press the SHIFT key to access numeric keys.
Disable default-features for both syn and quote
Fix clippy warning
bitflags 1.3 nix 0.23
Upgrade dependencies
Migrate to 2021 edition
Load terminal settings for VINTR, VQUIT, VSUSP on Unix
We just want to move cursor to the end of actual line: either edited line or interactive search line
Fix interrupted interactive search
Fix key_map initial capacity
Prepare release 9.1.0
Add reedline to similar projects
Fix clippy warnings
Revert to edition 2018
This is a reimplementation of kkawakam#338 which was reverted. When `Highligher::has_continuation_prompt` returns true, rustyline enables a special mode that passes the original prompt for every line to the highlighter, and highlighter is free to change color or characters of the prompt as long as it's length is the same (usual contract for the highlighter) Note: 1. Wrapped lines are not prefixed by prompt (this may be fixed in future releases either by prepending them, or by collapsing and scrolling lines wider than terminal). 2. Unlike kkawakam#338 this PR doesn't change the meaning of `cursor` and `end` fields of the `Layout` structure.
Collaborator
|
Thanks @ayazhafiz! |
Collaborator
|
I made a new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bumps the fork to be compatible with version 9.1.1 upstream while preserving the patch from kkawakam#372 that is used in the Roc CLI. The benefit of updating to 9.1.1 (or anything about 9.0) is that it includes kkawakam#518, which fixes roc-lang/roc#2285.