Skip to content

Vi: insert mode escape seq fallback to command mode#426

Merged
gwenn merged 3 commits intokkawakam:masterfrom
homburg:poc/vi-insert-seq-fallback-to-command-mode
Aug 14, 2020
Merged

Vi: insert mode escape seq fallback to command mode#426
gwenn merged 3 commits intokkawakam:masterfrom
homburg:poc/vi-insert-seq-fallback-to-command-mode

Conversation

@homburg
Copy link
Copy Markdown
Contributor

@homburg homburg commented Aug 5, 2020

Inspired by #416

In vi insert mode:

If getting an unrecognized escape sequence, assume it is a command input instead. eg Esc, j

We don't expect Meta-X in Vi insert mode only ANSI escape sequence.
So Meta-X means Esc (exit insert mode) and do command associated to X.
@homburg
Copy link
Copy Markdown
Contributor Author

homburg commented Aug 12, 2020

@gwenn I have updated this to call the new function vi_command_with_key to get the correct fast command mode switch behavior. Do you have any comments?

@gwenn
Copy link
Copy Markdown
Collaborator

gwenn commented Aug 13, 2020

@homburg
Copy link
Copy Markdown
Contributor Author

homburg commented Aug 14, 2020

@gwenn Great! Missed your pr (obviously). It works perfectly

@gwenn gwenn merged commit 00e7225 into kkawakam:master Aug 14, 2020
@gwenn
Copy link
Copy Markdown
Collaborator

gwenn commented Aug 14, 2020

Thanks.

@homburg homburg deleted the poc/vi-insert-seq-fallback-to-command-mode branch August 17, 2020 06:41
gwenn added a commit that referenced this pull request Sep 13, 2020
…mmand-mode

Vi: insert mode escape seq fallback to command mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants