Conversation
happy-eyeballs-lwt/happy-eyeballs-mirage: adapt to the API change
Contributor
Author
|
requires mirage/ocaml-dns#274 for the happy-eyeballs-lwt and happy-eyeballs-mirage packages |
Contributor
|
This looks good, but I am wondering if it would be smart to assert that |
Contributor
Author
|
I don't think that writing that |
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Oct 27, 2021
…s-lwt (0.1.0) CHANGES: * Remove assertion in timer, and fix the code (reported by @dinosaure in robur-coop/happy-eyeballs#17, fix in robur-coop/happy-eyeballs#18 by @hannesm, reviewed by @reynir) * Support OCaml 4.08 (robur-coop/happy-eyeballs#18 hannesm, requested in robur-coop/happy-eyeballs#16 by @smorimoto)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
happy-eyeballs-lwt/happy-eyeballs-mirage: adapt to the API change
//cc @reynir. this should fix #17