Skip to content

Relax OCaml lower bound to support >= 4.08#16

Closed
smorimoto wants to merge 1 commit into
robur-coop:mainfrom
smorimoto:relax-ocaml-lower-bound
Closed

Relax OCaml lower bound to support >= 4.08#16
smorimoto wants to merge 1 commit into
robur-coop:mainfrom
smorimoto:relax-ocaml-lower-bound

Conversation

@smorimoto
Copy link
Copy Markdown

As the title says.

Signed-off-by: Sora Morimoto <sora@morimoto.io>
@smorimoto
Copy link
Copy Markdown
Author

smorimoto commented Oct 21, 2021

This PR is intended to address the following an error that is not actually true when attempting to use conduit-mirage with OCaml >= 4.08 && < 4.10:

conduit-mirage >= 5.0.0 → dns-client >= 6.0.0 → happy-eyeballs >= 0.0.6 → ocaml >= 4.10.0

@hannesm
Copy link
Copy Markdown
Contributor

hannesm commented Oct 21, 2021

thanks for your PR, may I ask why you can't upgrade to OCaml 4.10?

@hannesm
Copy link
Copy Markdown
Contributor

hannesm commented Oct 21, 2021

also, List.concat_map is used in happy_eyeballs.ml, which is available only since OCaml 4.10, and the reason for the lower bound of this project.

hannesm added a commit that referenced this pull request Oct 27, 2021
@hannesm
Copy link
Copy Markdown
Contributor

hannesm commented Oct 27, 2021

in #18 we have the required code changes, the next release will be compatible with OCaml 4.08. thanks.

@hannesm hannesm closed this Oct 27, 2021
hannesm added a commit to hannesm/opam-repository that referenced this pull request Oct 27, 2021
…s-lwt (0.1.0)

CHANGES:

* Remove assertion in timer, and fix the code (reported by @dinosaure in robur-coop/happy-eyeballs#17,
  fix in robur-coop/happy-eyeballs#18 by @hannesm, reviewed by @reynir)
* Support OCaml 4.08 (robur-coop/happy-eyeballs#18 hannesm, requested in robur-coop/happy-eyeballs#16 by @smorimoto)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants