update sample with mocha test runner to jebtrains' new gradle plugin #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robstoll
changed the title
Codecov Report
@@ Coverage Diff @@
## master #690 +/- ##
==========================================
Coverage 87.37% 87.37%
- Complexity 16 121 +105
==========================================
Files 904 904
Lines 8161 8161
Branches 376 376
==========================================
Hits 7131 7131
Misses 953 953
Partials 77 77
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
robstoll
force-pushed
the
new-kotlin-js-plugin
branch
from
55afc94
to
3c4cd9a
Compare
robstoll
force-pushed
the
new-kotlin-js-plugin
branch
2 times, most recently
from
c981b95
to
003c4b6
Compare
We can further simplify it when we use the testSetup.kt file instead of the gradle task. In this case we do not require commonjs any more and we can also get rid of the NpxTask (as JetBrains' plugin seems to set it up already).
It is very unlikely someone uses JS with jasmine as jetbrains has setup everything with mocha
robstoll
force-pushed
the
new-kotlin-js-plugin
branch
3 times, most recently
from
e0581ef
to
31d3cc1
Compare
because of a Windows Server 2019 issue (or at least github action issue)
robstoll
force-pushed
the
new-kotlin-js-plugin
branch
from
31d3cc1
to
607ef0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I confirm that I have read the Contributor Agreements v1.0, agree to be bound on them and confirm that my contribution is compliant.