Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update js samples to use the new org.jetbrains.kotlin.js gradle plugin #473

Closed
robstoll opened this issue Apr 25, 2020 · 7 comments · Fixed by #690
Closed

update js samples to use the new org.jetbrains.kotlin.js gradle plugin #473

robstoll opened this issue Apr 25, 2020 · 7 comments · Fixed by #690
Assignees
Labels

Comments

@robstoll
Copy link
Owner

Platform (jvm, js, android): js
Extension (none, kotlin 1.3, jdk8): none

Non-Code related feature

The current samples for mocha and jasmine had been based on kotlin-examples which used the old kotlin plugin. By now, there is a new kotlin plugin (kotlin-examples is not updated though) but we could try to use the new Plugin instead.

The new plugin claims to have a few advantages

The plugin also provides useful testing features, for example:

  • Source maps generation
  • Test reports generation
  • Test run results in the console

So that sounds good. I guess it should be easy for mocha as the default runner they use is mocha but it might actually be hard for jasmine. Therefore I suggest to start with mocha only (first PR) and try afterwards if there is a way to reconfigure the plugin to use jasmine instead (second PR).

Following the description by JetBrains:
https://kotlinlang.org/docs/reference/js-project-setup.html

Your first contribution?

  • Write a comment I'll work on this if you would like to take this issue over.
    This way we get the chance to revise the description in case things have changed in the meantime, we might give you additional hints and we can assign the task to you, so that others do not start as well.
  • See Your first code contribution for guidelines.
  • Do not hesitate to ask questions here or to contact us via Atrium's slack channel if you need help
    (Invite yourself in case you do not have an account yet).
@robstoll robstoll changed the title update js samples to use the new kotlin gradle plugin update js samples to use the new org.jetbrains.kotlin.js gradle plugin Apr 25, 2020
@developerfred
Copy link

I'll work on this

@robstoll
Copy link
Owner Author

@developerfred nice 🙂
I just pushed some cleanups #474, please fork again or rebase on master once it is merged

@developerfred
Copy link

thanks @robstoll.

@robstoll
Copy link
Owner Author

@developerfred un-assigning so that pthers can take over. Let me know in case you still work on it.

@pablohildo
Copy link

I'll work on this.

@robstoll
Copy link
Owner Author

@pablohildo unassigning you so that others could take over

@chadmarchand
Copy link
Contributor

I'll work on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants