-
-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update js samples to use the new org.jetbrains.kotlin.js gradle plugin #473
Labels
Comments
robstoll
changed the title
update js samples to use the new kotlin gradle plugin
update js samples to use the new org.jetbrains.kotlin.js gradle plugin
Apr 25, 2020
I'll work on this |
@developerfred nice 🙂 |
thanks @robstoll. |
developerfred
added a commit
to developerfred/atrium
that referenced
this issue
Apr 26, 2020
@developerfred un-assigning so that pthers can take over. Let me know in case you still work on it. |
I'll work on this. |
@pablohildo unassigning you so that others could take over |
I'll work on this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Platform (jvm, js, android): js
Extension (none, kotlin 1.3, jdk8): none
Non-Code related feature
The current samples for mocha and jasmine had been based on kotlin-examples which used the old kotlin plugin. By now, there is a new kotlin plugin (kotlin-examples is not updated though) but we could try to use the new Plugin instead.
The new plugin claims to have a few advantages
So that sounds good. I guess it should be easy for mocha as the default runner they use is mocha but it might actually be hard for jasmine. Therefore I suggest to start with mocha only (first PR) and try afterwards if there is a way to reconfigure the plugin to use jasmine instead (second PR).
Following the description by JetBrains:
https://kotlinlang.org/docs/reference/js-project-setup.html
Your first contribution?
I'll work on this
if you would like to take this issue over.This way we get the chance to revise the description in case things have changed in the meantime, we might give you additional hints and we can assign the task to you, so that others do not start as well.
(Invite yourself in case you do not have an account yet).
The text was updated successfully, but these errors were encountered: