Feature/add specs maptocontain #1171
Conversation
| }.toThrow<AssertionError> { | ||
| message { | ||
| toContainSize(2, 3) | ||
| elementSuccess(0, "1", "a", "1") |
There was a problem hiding this comment.
shows only failing with report option
You are not expecting the contrary here. You should check that successful elements are not in the error report
There was a problem hiding this comment.
Hi, @robstoll
Thank you for reviewing. Asking questions you once before, how can I check that successful elements are not in the error report? I could not find the way to check specs I wrote...
There was a problem hiding this comment.
Sorry, did not get that this question was not solved yet. I remember that you were asking whether you can copy methods from IterableToContainsSepcBase to MapLikeToContainSpecBase. So yes, you totally can. You can for instance copy notToContainElement from there and adopt to map. I suggest we name the method notToContainEntry and it would suffice if it takes the key i.e it would look like follows:
fun Expect<String>.notToContainEntry(key: String): Expect<String> = ...
I left out the body on purpose, let me know if you don't want to figure this out yourself, I can also provide it.
There was a problem hiding this comment.
I suggest we name the method notToContainEntry and it would suffice if it takes the key i.e it would look like follows:
Thanks to provide some example. I understood that I could write expectation by toContainFun , but sould I create something like notToContainEntry ?
There was a problem hiding this comment.
Yes, you should create notToContainEntry in MapLikeToContainSpecBase
| ) | ||
| }.toThrow<AssertionError> { | ||
| message { | ||
| elementSuccess(0, "1", "a", "1") |
| }.toThrow<AssertionError> { | ||
| message { | ||
| toContainSize(2, 1) | ||
| elementSuccess(0, "1", "a", "1") |
There was a problem hiding this comment.
I guess you got it the wrong way, showOnlyFailingIfMoreExpectedElementsThan(2) is not met, hence it should show all successful expectations and all failing expectations
| } | ||
| } | ||
| } | ||
| it("shows summary without report option if there are 2 expected elements because default for showOnlyFailingIfMoreExpectedElementsThan is 2") { |
There was a problem hiding this comment.
default is 10 not 2. you need to state 10 expectations to be sure that it still shows the summary
There was a problem hiding this comment.
default is 10 not 2
I could not understand this... Why is the default value 10, not 2? Test data for spec is optional, I thought.
There was a problem hiding this comment.
report = {...} is optional exactly and you did not specify it here. If you leave it out then the default kicks in which is kind of:
report = { showOnlyFailingIfMoreExpectedElementsThan(10) }
| } | ||
| } | ||
| } | ||
| it("shows only failing without report option if there are 3 expected elements because default for showOnlyFailingIfMoreExpectedElementsThan is 2") { |
There was a problem hiding this comment.
same as above, the default is 10, so you should make 11 expectations about entries to see if only the failing are shown
| }.toThrow<AssertionError> { | ||
| message { | ||
| toContainSize(2, 3) | ||
| elementSuccess(0, "1", "a", "1") |
There was a problem hiding this comment.
Yes, you should create notToContainEntry in MapLikeToContainSpecBase
| expect { | ||
| expect(map).toContainFun( | ||
| keyValue("a") { toEqual(1) }, | ||
| report = { showOnlyFailingIfMoreExpectedElementsThan(1) } |
There was a problem hiding this comment.
Didn't see this before, you should do what you describe in it i.e. pass 2 and not 1 to showOnlyFailingIfMoreExpectedElementsThan
| report = { showOnlyFailingIfMoreExpectedElementsThan(1) } | |
| report = { showOnlyFailingIfMoreExpectedElementsThan(2) } |
Accordingly, you need to add two entry expectations to toContainFun to meet the criteria
Alternatively you can rewrite the it to:
it("shows summary with report option `showOnlyFailingIfMoreExpectedElementsThan(1)` because there are 1") {
| @@ -257,6 +256,87 @@ abstract class MapToContainInOrderOnlyKeyValueExpectationsSpec( | |||
|
|
|||
| context("report options") { | |||
| //TODO #1129 add tests, see IterableToContainInOrderOnlyValuesExpectationsSpec -> report options | |||
| context("") { | |||
There was a problem hiding this comment.
describe here what map is the subject, i.e. use
| context("") { | |
| context("map $map") { |
| } | ||
| } | ||
| } | ||
| it("shows summary without report option if there are 2 expected elements because default for showOnlyFailingIfMoreExpectedElementsThan is 2") { |
There was a problem hiding this comment.
report = {...} is optional exactly and you did not specify it here. If you leave it out then the default kicks in which is kind of:
report = { showOnlyFailingIfMoreExpectedElementsThan(10) }
|
@simonNozaki closing this, will take your commits as basis for a new PR. Thanks for the pre-work |
Outline
Add some specs to
MapToContainInOrderOnlyKeyValueExpectationsSpec.I made those reference to
IterableToContainInOrderOnlyValuesExpectationsSpec.Issue
#1129
I confirm that I have read the Contributor Agreements v1.0, agree to be bound on them and confirm that my contribution is compliant.