Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for reportOptions to MapToContainInOrderOnlyKeyValueExpectationsSpec #1129

Closed
1 task
robstoll opened this issue Apr 24, 2022 · 10 comments · Fixed by #1692
Closed
1 task

add tests for reportOptions to MapToContainInOrderOnlyKeyValueExpectationsSpec #1129

robstoll opened this issue Apr 24, 2022 · 10 comments · Fixed by #1692
Assignees
Labels
Milestone

Comments

@robstoll
Copy link
Owner

Platform (all, jvm, js): all
Extension (none, kotlin 1.3): none

Code related feature

Following the things you need to do:

  • see TODOs in MapToContainInOrderOnlyKeyValueExpectationsSpec

Your first contribution?

  • Write a comment I'll work on this if you would like to take this issue over.
    This way we get the chance to revise the description in case things have changed in the meantime, we might give you additional hints and we can assign the task to you, so that others do not start as well.
  • See Your first code contribution for guidelines.
  • Do not hesitate to ask questions here or to contact us via Atrium's slack channel if you need help
    (Invite yourself in case you do not have an account yet).
@simonNozaki
Copy link
Contributor

Hi @robstoll ,

I'll work on this. I'm new to open source projects, so would you support me where to start?

@robstoll
Copy link
Owner Author

@simonNozaki sure, I guess you had already a look at Your first code contribution. Note that adding a sample would probably be an easier issue to start with and as you are new, I recommend you work on one of those:
https://github.com/robstoll/atrium/issues?q=is%3Aopen+label%3A%22good+first+issue%22+sample

@simonNozaki
Copy link
Contributor

simonNozaki commented Jun 14, 2022

@robstoll
Thank you for your replying!

Note that adding a sample would probably be an easier issue to start with and as you are new

Yes, so I'll work on this:
#1045

@simonNozaki
Copy link
Contributor

@robstoll ,
Thanks to assign me to this issue. Can I add some methods or utilities to the base class of MapToContainInOrderOnlyKeyValueExpectationsSpec , MapLikeToContainFormatSpecBase ?

IterableToContainSpecBase (the base class of IterableToContainInOrderOnlyValuesExpectationsSpec) has those, so I suppose that it's better to match its example.

@robstoll
Copy link
Owner Author

Sure go ahead

@simonNozaki
Copy link
Contributor

Hi, @robstoll

I wrote the first spec in context, so how can I run specs? In locally, thgrough gradle, I ran ./gradlew :atrium-specs:jvmTest --info, but it seems that gradle could not look up test cases.

Though I checked wiki of this, repository, but I could not found the way to run.

@robstoll
Copy link
Owner Author

robstoll commented Jun 19, 2022

@simonNozaki specs only defines the specs in a parametric way. It's the tests of the Api modules you need to run in the end. easiest is you run ./gradlew build. If you want to be more specific, then run ./gradle :atrium-api-fluent-en_GB:test or :jvmTest

@robstoll
Copy link
Owner Author

@simonNozaki let me know in case you need help

@simonNozaki
Copy link
Contributor

Sorry, in these days i was so busy in my company, so I could not commit to this issue...

@robstoll
Copy link
Owner Author

@simonNozaki no worries and no hurry, just wanted to be sure you are not stuck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants