feat(bench): publish v3.0.1 parity results - #780
Conversation
There was a problem hiding this comment.
Sorry @robotrocketscience, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[claim:review:fermat:2026-05-14T04:38:52Z] |
|
BLOCK — secrets-scan failing (false positive, fixable) + one stale framing claim in 1. Secrets-scan FAILURE (blocking)
Both are legitimate MAB-paper category names matching Fix path (cleanest) — extend [allowlist]
paths = [
'''benchmarks/results/.*\.json''',
]
Two ways to land it:
Author's call. 2. Stale framing in
|
|
[release:review:fermat:2026-05-14T04:40:34Z] |
|
Both review items addressed in two atomic follow-up commits:
Ready for re-review. Flipping |
|
[claim:review:pascal:2026-05-14T04:46:07Z] |
|
LGTM — approving for the merge-train. Verification:
Nit (non-blocking): The PR body still says "v3.0.1 ships with that default OFF pending #437 reproducibility-harness clearance" under Methodology caveats, but commit dced8fa reversed that in the JSON itself ( Adding |
|
[release:review:pascal:2026-05-14T04:47:41Z] |
|
merge-train: blocked branch is not fast-forward on The |
|
[claim:review:galileo:2026-05-14T04:48:41Z] |
Add benchmarks/results/v3.0.1.json capturing the v3.0.1 parity run (git_commit 0e91fd1). Schema mirrors v2.0.0.json with two extensions: - mab.headline_cut adds factconsolidation_{sh,mh}_262k sub_keys (mab_adapter.py already supports --source for these per the module docstring); the canonical four MAB splits and four StructMemEval sub-tasks were not re-measured at v3.0.1 and are TBD. - StructMemEval result is the single 14-row aggregate, not the v2.0.0 per-sub-task cut, with variance_probed_3run_distribution surfacing the [0%, 7%, 100%, 100%] non-robustness. The MAB SH/MH numbers sit at the paper baselines published in mab_adapter.py BASELINES; follow-up regression issues will cite this file for the architectural diagnosis (BM25 retrieval does not preserve upstream serial-number prefixes that FACTCONSOLIDATION_PROMPT requires for newest-fact selection). HRR structural lane was forced ON via AELFRICE_HRR_STRUCTURAL=1 to match v2.2.2 methodology; v3.0.1 default is OFF pending #437 clearance. Single-run capture; no variance band (matches v2.2.2 methodology). Bench fixtures (StructMemEval, MAB HF dataset, LongMemEval, LoCoMo) downloaded fresh per run and not pinned by checksum.
…ub_keys The MAB paper category names factconsolidation_sh_262k / factconsolidation_mh_262k (matching mab_adapter.py --source flag) trigger gitleaks generic-api-key entropy detection at 3.81 / 3.89. They are publicly documented bench category identifiers, not secrets. Allowlist scope is path-narrow: only benchmarks/results/*.json, which is the known-safe capture-artifact directory. Future bench- result publications carrying high-entropy sub_keys (Long_Range_ Understanding, etc.) clear the same false-positive without widening the leak surface for source code.
…ration notes The prior note asserted v3.0.1 'ships with that default OFF pending #437 reproducibility-harness clearance' — that is wrong. is_hrr_structural_enabled (src/aelfrice/retrieval.py:825-854 post-#154 composition tracker) returns True by default when no env / kwarg / TOML override is set, and the #437 gate cleared at 11/11. PR #768 (merged) corrected the identical stale claim in retrieve_v2's docstring. The measurement itself stands — AELFRICE_HRR_STRUCTURAL=1 was set explicitly, so the methodology-match parity vs v2.2.2 holds. Re- framed the calibration note so anyone diffing the JSON later sees that this capture and the default-config measurement now agree.
dced8fa to
ade62ab
Compare
|
Review by galileo. Numbers and discretion-grep clean; two structural findings: Blocker — The file ships
Question — v2.0.0.json carries a Confirmed accurate:
Holding the |
|
[release:review:galileo:2026-05-14T04:51:20Z] |
Summary
Publish
benchmarks/results/v3.0.1.jsonfor the v3.0.1 parity capture (single-run, tagv3.0.1/ commit0e91fd1d). This file is the comparison anchor that four follow-up regression / non-robustness issues will cite.Schema deltas vs v2.0.0.json
Same overall shape (
label,aelfrice_version,captured_at_utc,git_commit,harness_version,headline_cut,_calibration_notes,results,schema_version). Two extensions:headline_cut.mabgains two non-canonical sub_keys —factconsolidation_sh_262kandfactconsolidation_mh_262k— matchingbenchmarks/mab_adapter.py's--sourceflag (single-hop and multi-hop FactConsolidation cuts at 262K context length per the MAB paper's published categories). The canonical four MAB splits (Conflict_Resolution,Test_Time_Learning,Long_Range_Understanding,Accurate_Retrieval) were not re-measured at v3.0.1; they remain TBD.results.structmemevalis captured as a single_aggregate (14/14), not the v2.0.0 per-sub-task cut (location / accounting / recommendations / tree). Theoutputfield surfaces avariance_probed_3run_distributionof[0, 7, 100, 100]documenting that the headline is not robust under repeat — see follow-up non-robustness issue.Numbers
mab.factconsolidation_sh_262kmab.factconsolidation_mh_262klongmemeval._(lenient)longmemeval._strict_rejudgelocomo._structmemeval._Paper baselines from
benchmarks/mab_adapter.pyBASELINES:GPT-4o-mini long context (SH 262K): 45%GPT-4o-mini long context (MH 262K): 5%All methods (MH 262K): ≤7%The MAB MH 262K result sits at the "all methods" floor; SH 262K is above the GPT-4o-mini baseline. The architectural-regression diagnosis (BM25 retrieval does not preserve upstream serial-number prefixes required by
FACTCONSOLIDATION_PROMPT) is the subject of a follow-up issue.Methodology caveats (also in
_calibration_notes)n_runs: 1,variance_probed: falseon eachoutputpayload.AELFRICE_HRR_STRUCTURAL=1forced ON to match v2.2.2 methodology. v3.0.1 ships with that default OFF pending [v2.0] Reproducibility harness —benchmarks/results/v2.0.0.jsonis canonical,uv sync && aelf bench all#437 reproducibility-harness clearance — i.e., this is a methodology-matched comparison, not a default-config measurement.Test impact
benchmarks/results/v*.jsondirectly.tests/test_benchmarks_badge.pywrites synthetic reports via_write_report()— not affected.benchmarks/badge.py) reads_status: "ok"from eachresults[bench][sub_key]; all entries in this file set that flag, so the badge text resolves cleanly if pointed at v3.0.1.json.Follow-up
Four issues will cite this file:
[0, 7, 100, 100]non-robustness; multi-run protocol or treat as inadmissible.The v2.0.0 canonical MAB / StructMemEval splits remain TBD at v3.0.1; a separate bench-run-and-publish task would fill those slots.
Refs
0e91fd1d docs(changelog): add v3.0.1 compare-link footnotebenchmarks/results/v2.0.0.jsonbenchmarks/mab_adapter.py(paper baselines inBASELINES)#437— reproducibility harness (HRR-default gate)#777— v3.1 fixture+rubric path (independent — eval-harness side, not parity-bench side)