build: drop dead tomli fallback (closes #330) - #339
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRemoves the now-unreachable File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 41 minutes and 29 seconds.Comment |
9a435b1 to
e578785
Compare
`requires-python = ">=3.12"` makes the `try: import tomllib / except ImportError: import tomli` fallback unreachable; stdlib tomllib ships in 3.11+. Drop the try/except and the matching DEP003 deptry ignore. Resigned, signed-commit version: prior PRs #332 and #337 had identical diffs but were unsigned after the auto-rebase workflow rewrote them as github-actions[bot]; ruleset requires signatures, so neither was mergeable. Closing both as superseded.
e578785 to
1613633
Compare
|
[claim:review:Setr:2026-05-01T16:06:44Z] |
|
[release:review:Setr:2026-05-01T16:08:01Z] |
Summary
Closes #330 option A.
pyproject.tomldeclaresrequires-python = ">=3.12", so thetomlifallback insrc/aelfrice/deferred_feedback.py:46-49is unreachable (stdlibtomllibships in 3.11+). Drop the try/except and the matching DEP003 deptry ignore.Why a third PR
Prior #332 and #337 had byte-identical diffs but the auto-rebase workflow rewrote both as
github-actions[bot](no signing key), and the branch ruleset requires signed commits. Result: neither was mergeable. This PR re-applies the same change as a freshly signed commit so it can land. Filing the auto-rebase signing strip as a separate ruleset/CI bug.Verification
uv run python -c "from aelfrice import deferred_feedback"→ import ok.uvx deptry src→ "Success! No dependency issues found."Closes #330. Supersedes #332 and #337.
Summary by Sourcery
Remove the obsolete tomli fallback now that the project requires Python 3.12+ and relies solely on the standard-library tomllib.
Enhancements:
Build: