fix: drop dead tomli fallback (closes #330) - #337
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe changes implement Option A from issue Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR removes an obsolete fallback dependency on File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
`requires-python = ">=3.12"` makes the `try: import tomllib / except ImportError: import tomli` fallback unreachable. Replace with the direct stdlib import and drop the matching DEP003 deptry ignore. Closes #330.
9650c1f to
cc2094f
Compare
`requires-python = ">=3.12"` makes the `try: import tomllib / except ImportError: import tomli` fallback unreachable; stdlib tomllib ships in 3.11+. Drop the try/except and the matching DEP003 deptry ignore. Resigned, signed-commit version: prior PRs #332 and #337 had identical diffs but were unsigned after the auto-rebase workflow rewrote them as github-actions[bot]; ruleset requires signatures, so neither was mergeable. Closing both as superseded.
`requires-python = ">=3.12"` makes the `try: import tomllib / except ImportError: import tomli` fallback unreachable; stdlib tomllib ships in 3.11+. Drop the try/except and the matching DEP003 deptry ignore. Resigned, signed-commit version: prior PRs #332 and #337 had identical diffs but were unsigned after the auto-rebase workflow rewrote them as github-actions[bot]; ruleset requires signatures, so neither was mergeable. Closing both as superseded.
Summary
pyproject.tomldeclaresrequires-python = ">=3.12". Stdlibtomllibarrived in 3.11. Thetry: import tomllib / except ImportError: import tomlifallback insrc/aelfrice/deferred_feedback.py:46-49is therefore unreachable code. Replace with the direct stdlib import and drop the matching DEP003 deptry ignore.Verification
uv run pytest tests/ -q→ 1982 passed, 18 skipped.uvx deptry src→ "Success! No dependency issues found."git grep -n tomli→ only the now-removed comment in the deptry config block; no remainingtomlireferences.Closes #330.
Summary by Sourcery
Remove the obsolete tomli fallback now that the project targets Python 3.12+ and clean up the corresponding dependency tooling configuration.
Enhancements:
Build:
Summary by CodeRabbit
tomllibmodule, removing support for legacy Python compatibility fallbacks.