Switch 3rdparty directory to only download files if YCM_DOWNLOAD_3RDPARTY is set to ON #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PeterBowman any opinion on this? Asking as you commented in the related issue in #105 (comment) . |
I think I've not seen that error (GitLab was down and UseLatex.cmake could not be downloaded) in a long time, but this is great as it shields us against similar issues in the future. |
Nicogene
approved these changes
Apr 7, 2022
|
Example of problem avoided after this PR (from https://github.com/robotology/gazebo-yarp-plugins/runs/7275245883):
|
In this specific case, https://invent.kde.org/frameworks/extra-cmake-modules/-/raw/v5.79.0/find-modules/FindUDev.cmake is marked as 403, but all other files are accessible (see for example https://invent.kde.org/frameworks/extra-cmake-modules/-/raw/v5.80.0/find-modules/FindUDev.cmake). I wonder if YCM (and its use in CI systems) played a role in the reason why that URL is now not accessible. I guess that anyhow we should not risk these problems anymore after this PR. |
This was referenced Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
YCM_DOWNLOAD_3RDPARTYis set toOFF, the already downloaded files committed in the repo are used instead.The main goal of this is to shift the burden of downloading new 3rdparty files from the users to the mantainer, that once in a while will need to update the files and run the build with
YCM_DOWNLOAD_3RDPARTYoption enabled. This should reduce the time necessary to install YCM from source, including when YCM is used for bootstrap. Furtermore, it reduces the possibility that the YCM build fails, as even ifgitlab.org,gitlab.kitware.comorinvent.kde.orgare down, the YCM build will successed anyhow.This should also have the side effect of speeding up the build of YCM.
Fix #105 .