Fix compilation against graphviz 3 on Windows #2851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update the release notes by adding a file in |
randaz81
previously approved these changes
Jun 10, 2022
This was referenced Jun 10, 2022
traversaro
changed the title
Done in 25a6787 . |
randaz81
approved these changes
Jun 13, 2022
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since version 3, Graphviz requires downstream users to define
GVDLLto link correctly on Windows when using a Graphviz shared library. This change (together with upcoming YCM release 0.14.2: robotology/ycm-cmake-modules#414) fixes the compilation of YARP against graphviz 3.If an older YCM version is used, nothing happens (so there is no need to bump the required YCM version).