Remove legacy workarounds in conda-forge GitHub Actions job

[traversaro]

🦟 Bug fix

Summary

In #3223 (comment) we added some workarounds for the conda-forge CI, namely pin the version of some dependencies and removed dartsim. Now that the long term fixes to that problems (linked in #3223 (comment)) has been fixed, we can remove the workarounds.

Checklist

• Signed all commits for DCO
• Added tests
• Updated documentation (as needed)
• Updated migration guide (as needed)
• Consider updating Python bindings (if the library has them)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

[mjcarroll]

LGTM with green Conda CI.

[traversaro]

After this PR we have a failure on Windows:

2022-10-26T19:32:46.1070462Z [855/1154] Linking CXX shared library gazebo\gui\gazebo_gui.dll
2022-10-26T19:32:46.1071093Z FAILED: gazebo/gui/gazebo_gui.dll gazebo/gui/gazebo_gui.lib 
2022-10-26T19:32:46.1072232Z cmd.exe /C "cd . && C:\Miniconda\envs\test\Library\bin\cmake.exe -E vs_link_dll --intdir=gazebo\gui\CMakeFiles\gazebo_gui.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100226~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100226~1.0\x64\mt.exe --manifests  -- C:\PROGRA~2\MICROS~2\2019\ENTERP~1\VC\Tools\MSVC\1429~1.301\bin\Hostx64\x64\link.exe /nologo @CMakeFiles\gazebo_gui.rsp  /out:gazebo\gui\gazebo_gui.dll /implib:gazebo\gui\gazebo_gui.lib /pdb:gazebo\gui\gazebo_gui.pdb /dll /version:11.12 /machine:x64 /INCREMENTAL:NO  && cd ."
2022-10-26T19:32:46.1073755Z LINK: command "C:\PROGRA~2\MICROS~2\2019\ENTERP~1\VC\Tools\MSVC\1429~1.301\bin\Hostx64\x64\link.exe /nologo @CMakeFiles\gazebo_gui.rsp /out:gazebo\gui\gazebo_gui.dll /implib:gazebo\gui\gazebo_gui.lib /pdb:gazebo\gui\gazebo_gui.pdb /dll /version:11.12 /machine:x64 /INCREMENTAL:NO /MANIFEST /MANIFESTFILE:gazebo\gui\gazebo_gui.dll.manifest" failed (exit code 1120) with the following output:
2022-10-26T19:32:46.1074685Z    Creating library gazebo\gui\gazebo_gui.lib and object gazebo\gui\gazebo_gui.exp
2022-10-26T19:32:46.1075696Z QGVScene.cpp.obj : error LNK2019: unresolved external symbol AgMemDisc referenced in function "public: static struct Agraph_s * __cdecl QGVCore::agmemread2(char const *)" (?agmemread2@QGVCore@@SAPEAUAgraph_s@@PEBD@Z)
2022-10-26T19:32:46.1076604Z QGVScene.cpp.obj : error LNK2019: unresolved external symbol AgIdDisc referenced in function "public: static struct Agraph_s * __cdecl QGVCore::agmemread2(char const *)" (?agmemread2@QGVCore@@SAPEAUAgraph_s@@PEBD@Z)
2022-10-26T19:33:01.0349616Z QGVScene.cpp.obj : error LNK2019: unresolved external symbol AgIoDisc referenced in function "public: static struct Agraph_s * __cdecl QGVCore::agmemread2(char const *)" (?agmemread2@QGVCore@@SAPEAUAgraph_s@@PEBD@Z)
2022-10-26T19:33:01.0353344Z 
2022-10-26T19:33:01.0354132Z QGVScene.cpp.obj : error LNK2019: unresolved external symbol Agdirected referenced in function "public: __cdecl QGVScene::QGVScene(class QString const &,class QObject *)" (??0QGVScene@@QEAA@AEBVQString@@PEAVQObject@@@Z)
2022-10-26T19:33:01.0354698Z 
2022-10-26T19:33:01.0355152Z gazebo\gui\gazebo_gui.dll : fatal error LNK1120: 4 unresolved externals

[traversaro]

We did not noticed that in the feedstock as graphviz was not enabled on Windows, this PR conda-forge/gazebo-feedstock#154 should fix it.

[traversaro]

Before this PR, graphviz 2.50 was used and everything was working fine.

[traversaro]

I think the problem is exactly the same described in robotology/robotology-superbuild#1152 and fixed in robotology/ycm-cmake-modules#414 and robotology/yarp#2851 .

[scpeters]

I think the problem is exactly the same described in robotology/robotology-superbuild#1152 and fixed in robotology/ycm#414 and robotology/yarp#2851 .

so we could add Graphviz_DEFINITIONS here as well to fix it?

[traversaro]

I think the problem is exactly the same described in robotology/robotology-superbuild#1152 and fixed in robotology/ycm#414 and robotology/yarp#2851 .

so we could add Graphviz_DEFINITIONS here as well to fix it?

Exactly, I plan to do that, but in a separate PR to make sure that that works fine also with graphviz 2.50 .

[scpeters]

I think the problem is exactly the same described in robotology/robotology-superbuild#1152 and fixed in robotology/ycm#414 and robotology/yarp#2851 .

so we could add Graphviz_DEFINITIONS here as well to fix it?

Exactly, I plan to do that, but in a separate PR to make sure that that works fine also with graphviz 2.50 .

ok, sounds good!

[scpeters]

feel free to merge if you're ready