-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for D405 #40
Conversation
The PR has been converted to a draft as I would like to discuss the changes with @randaz81 first. |
Given the tests we have done and considering IntelRealSense/librealsense#11784, I have decided to add a specific section in the |
…) to support the RealSense D405 camera
… the configuration of the depth stream
…he configuration of the color stream
After the code review I made f2f also with @randaz81, we decided it was better to make more explicit the section with the exceptions for the D405 at the cost to have a bit more redundant code but more readable. I pushed the changes. A part from this, I am going to test the device after these changes with all the cameras we have next week and then I'll mark the PR as ready. cc @Nicogene |
I tested the device with this PR changes, by visualizing both RGB and depth, on
Hence, I am marking this PR as ready. |
Sorry @xEnVrE, I forgot this. Can you add a line to the CHANGELOG.md for this change? Thanks! So we can do a release with this change. |
This makes some modifications to
realsense2Driver::initializeRealsenseDevice()
,realsense2Driver::setDepthResolution()
andrealsense2Driver::setRgbResolution()
so that theD405
camera is supported.The changes to
realsense2Driver::setRgbResolution()
andrealsense2Driver::setDepthResolution()
are probably desirable independently from theD405
as these methods should only change the configuration for the part they compete to, i.e. color and depth parameters respectively.Fixes #39
cc @randaz81 @traversaro