Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whole Body Controllers Release 2.5 #70

Closed
15 tasks done
gabrielenava opened this issue Oct 10, 2019 · 9 comments
Closed
15 tasks done

Whole Body Controllers Release 2.5 #70

gabrielenava opened this issue Oct 10, 2019 · 9 comments
Assignees
Labels

Comments

@gabrielenava
Copy link
Collaborator Author

I've increased the priority of the release and of the associated issues, with the objective of doing a sprint and close the release.

@gabrielenava
Copy link
Collaborator Author

gabrielenava commented Mar 18, 2020

CHANGELOG V2.5 (to be copied in the release description)

New features

Enhancements

Documentation

Installation

@gabrielenava
Copy link
Collaborator Author

Almost finished: when #92 and robotology/robotology-superbuild#367 will be merged, the 2.5 release will be done.

@traversaro
Copy link
Member

Almost finished: when #92 and robotology/robotology-superbuild#367 will be merged, the 2.5 release will be done.

Not a blocker for the 2.5 release (actually it is a modification that needs to be done **after the 2.5 release), but I think we should also modify the superbuild to install whole-body-controllers also when ROBOTOLOGY_USES_MATLAB is disabled.

@gabrielenava
Copy link
Collaborator Author

gabrielenava commented Mar 23, 2020

TODO after merging:

  • create the release and update the readme; ✔️

  • Modify the superbuild to install whole-body-controllers also when ROBOTOLOGY_USES_MATLAB is disabled;

  • Update the superbuild and WBC documentation accordingly;

  • Consistency check for all the hyperlinks in the readmes; ✔️

  • Add link to the new Simulink-only controller in the wiki. ✔️

@gabrielenava
Copy link
Collaborator Author

Not a blocker for the 2.5 release (actually it is a modification that needs to be done **after the 2.5 release), but I think we should also modify the superbuild to install whole-body-controllers also when ROBOTOLOGY_USES_MATLAB is disabled.

@traversaro I was addressing this point but I have some questions:

  • Looking at the CMakeLists of robotology-superbuild, there is also the option ROBOTOLOGY_NOT_USE_SIMULINK. Should I bring whole-body-controllers out of both the tags? do we still need the ROBOTOLOGY_NOT_USE_SIMULINK tag or it can be removed (it seems it is used only in that line);

  • So if I install whole-body-controllers without Matlab on my pc, it should just clone the repo and install the home positions and the library. The option for autogeneration is OFF, but what happens if a user turn it on without Matlab? should we consider also this hypothesis?

  • I think we should also document in the superbuild README that if WBC is installed without Matlab, its functionalities are reduced.

@traversaro
Copy link
Member

Looking at the CMakeLists of robotology-superbuild, there is also the option ROBOTOLOGY_NOT_USE_SIMULINK. Should I bring whole-body-controllers out of both the tags? do we still need the ROBOTOLOGY_NOT_USE_SIMULINK tag or it can be removed (it seems it is used only in that line);

Mhh, ROBOTOLOGY_NOT_USE_SIMULINK is useful for avoiding failures in BlockFactory if Matlab is compiled but Simulink is not, the fact that is used only there sounds like a regression. Probably the USES_MATLAB option of BlockFactory (see https://github.com/robotology/robotology-superbuild/blob/bdf3b7c5f4d7d2531e8c566058937558f23de649/cmake/BuildBlockFactory.cmake#L13) should depend on the value of ROBOTOLOGY_NOT_USE_SIMULINK. However, this is unrelated.

So if I install whole-body-controllers without Matlab on my pc, it should just clone the repo and install the home positions and the library.

Yes. The reason we did not install it in the past even if it was harmless do to so in a system where ROBOTOLOGY_USES_MATLAB is disabled was to save clone time and space on disk, but given that it is now useful we can just download and install it in any case.

The option for autogeneration is OFF, but what happens if a user turn it on without Matlab? should we consider also this hypothesis?

No, we only care for the default options and for the options that are exposed in the superbuild CMake.

I think we should also document in the superbuild README that if WBC is installed without Matlab, its functionalities are reduced.

You can probably mention that either in the ROBOTOLOGY_ENABLE_DYNAMICS or ROBOTOLOGY_USES_MATLAB docs.

@gabrielenava
Copy link
Collaborator Author

WBC readme updated and PR opened.

Once the PR will be finished, I'll close this issue and the 2.5 release will be officially concluded.

@gabrielenava
Copy link
Collaborator Author

The PR has been merged. Closing, the release is officially concluded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants