Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Conda documentation - add Soxr dependency #1087

Merged
merged 3 commits into from
Apr 8, 2022

Conversation

HosameldinMohamed
Copy link
Contributor

This should fix #1008

@traversaro
Copy link
Member

Can you add the installation also in CI, see https://github.com/HosameldinMohamed/robotology-superbuild/blob/updateDocSoxr/.github/workflows/ci.yml#L80 ? Unfortunatly we still have this info duplicated.

@HosameldinMohamed
Copy link
Contributor Author

Can you add the installation also in CI, see https://github.com/HosameldinMohamed/robotology-superbuild/blob/updateDocSoxr/.github/workflows/ci.yml#L80 ? Unfortunatly we still have this info duplicated.

I had missed that. done in b924f22

@traversaro
Copy link
Member

Please ignore the Unstable CI failures. They are regression of robotology/ycm-cmake-modules#401 that will be fixed by robotology/icub-main#787 .

@traversaro
Copy link
Member

For consistency I would also update the apt dependencies adding libsoxr-dev in https://github.com/robotology/robotology-superbuild/blob/master/apt.txt (fortunatly this list is used both by docs and CI, so in this case you just need to update a single file).

@HosameldinMohamed
Copy link
Contributor Author

For consistency I would also update the apt dependencies adding libsoxr-dev in https://github.com/robotology/robotology-superbuild/blob/master/apt.txt (fortunatly this list is used both by docs and CI, so in this case you just need to update a single file).

done in f800166

@traversaro
Copy link
Member

Thanks @HosameldinMohamed !

@traversaro traversaro merged commit 13bbf83 into robotology:master Apr 8, 2022
@HosameldinMohamed HosameldinMohamed deleted the updateDocSoxr branch April 8, 2022 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to find soxr.h (from conda-forge dependencies installation on Manjaro)
2 participants