Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix of BSP of the board amcfoc to run EEPROM #538

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

SanLordKevin
Copy link
Contributor

@SanLordKevin SanLordKevin commented Nov 27, 2024

This PR fixes the SPI 3 pin configuration inside embot::hw::spi::bsp. Now the embot::hw::eeprom works fine.

I have also inserted some macros in main.cpp of the test project to better test the code.

There are some macros and portion of the code commented for testing, I left them commented as their use depend on the specific test to do.

@SanLordKevin SanLordKevin self-assigned this Nov 27, 2024
@marcoaccame marcoaccame changed the title SPI 3 fix pin configuration Fix of BSP of the board amcfoc to run EEPROM Nov 27, 2024
Copy link
Contributor

@marcoaccame marcoaccame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is fine.

We can merge as these changes touch only the amcfoc board.

@marcoaccame marcoaccame merged commit 4eef98a into robotology:devel Nov 27, 2024
@SanLordKevin SanLordKevin deleted the amcfoc_EEPROM branch November 27, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants