Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct disabling of led toggling at 100ms wrongly removed in previous fw #432

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Correct disabling of led toggling at 100ms wrongly removed in previous fw #432

merged 1 commit into from
Oct 27, 2023

Conversation

MSECode
Copy link
Contributor

@MSECode MSECode commented Oct 26, 2023

Re-enabled a line for the LED toggling.

@MSECode MSECode self-assigned this Oct 26, 2023
@MSECode MSECode requested a review from valegagge October 26, 2023 08:42
@MSECode MSECode mentioned this pull request Oct 26, 2023
Merged
@marcoaccame marcoaccame changed the title Correct disabling of led toggling at 100ms wrongly removed in preious fw Correct disabling of led toggling at 100ms wrongly removed in previous fw Oct 26, 2023
@marcoaccame marcoaccame self-requested a review October 26, 2023 09:18
marcoaccame
marcoaccame approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@marcoaccame marcoaccame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MSECode, it is OK by me. If tested we can merge.

valegagge
valegagge approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@valegagge valegagge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@valegagge valegagge merged commit dc484be into robotology:devel Oct 27, 2023
@MSECode MSECode deleted the fix/ledToggling branch October 27, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoaccame marcoaccame marcoaccame approved these changes

@valegagge valegagge valegagge approved these changes

Assignees

@MSECode MSECode

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MSECode @valegagge @marcoaccame