Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handling of status messages for BAT and BMS in EMS baord #403

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

MSECode
Copy link
Contributor

@MSECode MSECode commented Jul 28, 2023

This PR introduces the following changes:

  • Add data regarding CAN message with StdId 0x629 used in BAT code for sending data regarding status of the board
  • Define CAN messages for sending to EMS board from BAT the status info and wrap in #ifdef clause the message not parsed by EMS board but used by custom application
  • Define in EMS fw parsing for BMS and BAT status and define related protocol methods in map s_eo_canprot_functions_periodicBattery and CAN_protocol_BS callbacks, which are left commented for AMC board
  • Update versions for fw which will be pushed to icub-firmware-build

@MSECode
Copy link
Contributor Author

MSECode commented Jul 28, 2023

NOTE for @MSECode PRs:
Third PR to be merged.

@MSECode MSECode force-pushed the feature/batteryStatus branch from 7d2b6f7 to 86c4c7e Compare August 1, 2023 13:50
@marcoaccame
Copy link
Contributor

HI @MSECode, so far it seems OK. A new version for the amc application is maybe missing. When you are ready for review I will complete the review

@MSECode
Copy link
Contributor Author

MSECode commented Aug 2, 2023

Oks, I'll set to ready after tests on robots R1 and ergoCub.

@MSECode MSECode force-pushed the feature/batteryStatus branch from dc6e4fb to 6189461 Compare August 9, 2023 15:09
@MSECode MSECode force-pushed the feature/batteryStatus branch from da6a190 to 8ad8b1c Compare September 7, 2023 10:23
Improve message handling in EMS filtering messages to be parsed
Add varibale to keep values of voltage in deciVolt and fix status for R1
Used ifdef instead of comments for unused messages
Update version and add commented BAT protocol methods in amc callbacks
Update status to uint32_t containing BMS and BAT status
Update versions and bat project file for improving the compiler version
@MSECode MSECode force-pushed the feature/batteryStatus branch from f0690b0 to 6e01f58 Compare September 7, 2023 12:53
@MSECode MSECode marked this pull request as ready for review September 7, 2023 13:03
@MSECode
Copy link
Contributor Author

MSECode commented Sep 7, 2023

Ready for review. Code tested and PRs mentioned here all opened and ready

@pattacini pattacini requested a review from valegagge September 7, 2023 13:05
@Nicogene Nicogene merged commit 9e35054 into robotology:devel Sep 8, 2023
@MSECode MSECode deleted the feature/batteryStatus branch September 25, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants