Skip to content

Fix for selected row not being updated & performance #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix for selected row not being updated & performance #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
84c5bf2
Update README.md
robcalcroft Feb 15, 2017
0df32eb
Merge remote-tracking branch 'robcalcroft/master'
pcmogollon Feb 16, 2017
e8411ab
Fix for selection updates
pcmogollon Feb 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions MultiSelect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,13 @@ class MultiSelect extends Component {
}
}

shouldComponentUpdate(nextProps) {
shouldComponentUpdate(nextProps, nextState) {
// This is a performance check as this sometimes gets updated often
if (nextProps.selectedOptions.length === this.props.selectedOptions.length) {
if (nextProps.selectedOptions === this.props.selectedOptions &&
Copy link
Owner

@robcalcroft robcalcroft Feb 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make this if look like this please:

if (
  (variable === variable) &&
  (varible1 === variable1)
) {
  // do things here
}

I prefer this more verbose option for multiline stuff

nextState.selectedRows === this.state.selectedRows) {
return false;
}

return true;
}

Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ list.
A React Native style object, you can also pass StyleSheet styles to this; they
will be flattened.

## `listViewProps{}`
### `listViewProps{}`
An object of props that are given to the ListView, this for things like `renderHeader`

### `activeOpacity` `Number`
Expand Down