Fix for selected row not being updated & performance #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* When a row was selected it was not rerendered. * Enhanced performance issue
robcalcroft
reviewed
Feb 20, 2017
| shouldComponentUpdate(nextProps, nextState) { | ||
| // This is a performance check as this sometimes gets updated often | ||
| if (nextProps.selectedOptions.length === this.props.selectedOptions.length) { | ||
| if (nextProps.selectedOptions === this.props.selectedOptions && |
There was a problem hiding this comment.
Could you make this if look like this please:
if (
(variable === variable) &&
(varible1 === variable1)
) {
// do things here
}I prefer this more verbose option for multiline stuff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.