Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates token holder extension to match erc-7590. #253

Merged
merged 3 commits into from
Jan 9, 2024
Merged

Conversation

steven2308
Copy link
Member

@steven2308 steven2308 commented Jan 9, 2024

Also improves interfaces naming and comments.

Checklist

  • Verified code additions
  • Updated NatSpec comments (if applicable)
  • Regenerated docs
  • Ran prettier
  • Added tests to fully cover the changes

PR-Codex overview

Detailed summary

  • This PR focuses on the implementation of the IERC7590 interface.
  • Notable changes include:
    • Renaming of IRMRKTokenHolder to IERC7590.
    • Addition of IERC7590 interface with methods for transferring ERC-20 tokens and retrieving balances.
    • Update of related code and documentation.

The following files were skipped due to too many changes: docs/RMRK/extension/tokenHolder/IERC7590.md, docs/RMRK/extension/tokenHolder/RMRKTokenHolder.md, contracts/RMRK/extension/tokenHolder/RMRKTokenHolder.sol, test/extensions/tokenHolder.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@steven2308 steven2308 merged commit 9e783bf into dev Jan 9, 2024
4 checks passed
@steven2308 steven2308 deleted the erc-7590 branch January 9, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant