Skip to content

Commit

Permalink
Updates docs.
Browse files Browse the repository at this point in the history
  • Loading branch information
steven2308 committed Jan 9, 2024
1 parent 7f0ecd8 commit 9e783bf
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 5 deletions.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,5 +33,6 @@ So far we have created 6 modules as ERC proposals, all of which are ERC721 compa
- Soulbound: [ERC-6454: Minimal Transferable NFT detection interface](https://eips.ethereum.org/EIPS/eip-6454)
- Emotable: [ERC-7409: Public Non-Fungible Tokens Emote Repository](https://eips.ethereum.org/EIPS/eip-7409)
- Dynamic Attributes: [ERC-7508: Dynamic On-Chain Token Attributes Repository ](https://eips.ethereum.org/EIPS/eip-7508)
- ERC20-Holder: [ERC-7590: ERC-20 Holder Extension for NFTs ](https://eips.ethereum.org/EIPS/eip-7590)

![RMRK Modules](/img/General_Overview_Modules.png)
6 changes: 3 additions & 3 deletions contracts/RMRK/extension/tokenHolder/IERC7590.sol
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// SPDX-License-Identifier: Apache-2.0
// SPDX-License-Identifier: CC0-1.0

pragma solidity ^0.8.21;

Expand Down Expand Up @@ -47,8 +47,8 @@ interface IERC7590 is IERC165 {
/**
* @notice Transfer ERC-20 tokens from a specific token.
* @dev The balance MUST be transferred from this smart contract.
* @dev Implementers should validate that the `msg.sender` is either the token owner or approved to manage it before calling this.
* @dev Must increase the transfer-out-nonce for the tokenId
* @dev MUST increase the transfer-out-nonce for the tokenId
* @dev MUST revert if the `msg.sender` is not the owner of the NFT or approved to manage it.
* @param erc20Contract The address of the ERC-20 smart contract
* @param tokenId The ID of the token to transfer the ERC-20 tokens from
* @param amount The number of ERC-20 tokens to transfer
Expand Down
2 changes: 1 addition & 1 deletion docs/RMRK/extension/tokenHolder/IERC7590.md
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ function transferHeldERC20FromToken(address erc20Contract, uint256 tokenId, addr

Transfer ERC-20 tokens from a specific token.

*The balance MUST be transferred from this smart contract.Implementers should validate that the `msg.sender` is either the token owner or approved to manage it before calling this.Must increase the transfer-out-nonce for the tokenId*
*The balance MUST be transferred from this smart contract.MUST increase the transfer-out-nonce for the tokenIdMUST revert if the `msg.sender` is not the owner of the NFT or approved to manage it.*

#### Parameters

Expand Down
2 changes: 1 addition & 1 deletion docs/RMRK/extension/tokenHolder/RMRKTokenHolder.md
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ function transferHeldERC20FromToken(address erc20Contract, uint256 tokenId, addr

Transfer ERC-20 tokens from a specific token.

*The balance MUST be transferred from this smart contract.Implementers should validate that the `msg.sender` is either the token owner or approved to manage it before calling this.Must increase the transfer-out-nonce for the tokenId*
*The balance MUST be transferred from this smart contract.MUST increase the transfer-out-nonce for the tokenIdMUST revert if the `msg.sender` is not the owner of the NFT or approved to manage it.*

#### Parameters

Expand Down

0 comments on commit 9e783bf

Please sign in to comment.