Update react is/1209 valid element type#2196
Closed
wegry wants to merge 2 commits intorjsf-team:masterfrom
Closed
Conversation
dd04ab9 to
7d07a8f
Compare
7 tasks
5 tasks
753c97a to
9fff0dc
Compare
Member
|
Why close this PR?
…--
Ashwin Ramaswami
On Wed, Dec 8, 2021 at 12:09 PM Zach Wegrzyniak ***@***.***> wrote:
Closed #2196
<#2196>.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2196 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAM4MX5DOBB33YGHFBYEPI3UP6GOBANCNFSM4WFOHVVQ>
.
|
Contributor
Author
Member
|
Okay, thanks. Best of luck with everything else!
…--
Ashwin Ramaswami
On Wed, Dec 8, 2021 at 12:45 PM Zach Wegrzyniak ***@***.***> wrote:
@epicfaace <https://github.com/epicfaace> #2478 (comment)
<#2478 (comment)>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2196 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAM4MX2VEF2GPHD2AXJSBWTUP6KTJANCNFSM4WFOHVVQ>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
This adds a test around my project's desire to break a moment (and moment-tz) dependency out of our main rjsf chunk by using React's Suspense.
This is an update to @jonathanhawleypeters's existent PR in #1737.
If this is related to existing tickets, include links to them as well.
I believe there are a few, but among others:
#1209
#2039
Checklist