uses ReactIs.isValidElementType to check widget types#1737
Closed
jonathanhawleypeters wants to merge 1 commit intorjsf-team:masterfrom
Closed
uses ReactIs.isValidElementType to check widget types#1737jonathanhawleypeters wants to merge 1 commit intorjsf-team:masterfrom
jonathanhawleypeters wants to merge 1 commit intorjsf-team:masterfrom
Conversation
rjsf-team/react-json-schema-form#1209
epicfaace
approved these changes
Apr 30, 2020
epicfaace
requested changes
May 18, 2020
| ReactIs.isMemo(widget) | ||
| ) { | ||
| if (typeof widget !== "string" && ReactIs.isValidElementType(widget)) { | ||
| return mergeOptions(widget); |
Member
There was a problem hiding this comment.
Since our old tests didn't catch this issue, would it be possible to update them so that we don't regress again?
Author
There was a problem hiding this comment.
Yes, I'll do that soon. Thanks for the reminder
7 tasks
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please leave a comment if this is still an issue for you. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Since React 16.3.0 components created by
React.forwardRefmay be an object. According to the guidelines, react-is should be used for type validation.#1209
Checklist