maint: add cpp fix for clipping #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luigi-rosso
approved these changes
Oct 4, 2022
rive-engineering
pushed a commit
that referenced
this pull request
Dec 5, 2024
This pull request addresses the following GitHub issues and more: - [rive-ios #345](rive-app/rive-ios#345) - [rive-react-native #268](rive-app/rive-react-native#268) Thanks to some help from @luigi-rosso, we discovered that the iOS runtime build scripts were _not_ including the Yoga renames, causing a collision when some frameworks were statically linked in React Native environments. This has been tested locally, and works, but the real test will be the public. Diffs= 437688c18e Add yoga renames to non-v2 lua build scripts (#8693)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downstream cpp fix fixes an issue around nested artboards with non-zero origins where clipping to keep AABB rect in the expected frame