-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App crashes on IOS for RN = 0.75.4 #268
Comments
I am facing the same issue in react-native 0.75.3 and rive-react-native 7.3.0 |
@kcadi @imsankalp This has been brought up internally and is currently being discussed. No update to share at this exact time. |
@dskuza I've reported the same issue on rive-app/rive-ios#345 with a bit of added context It looks like a symbol collision between RiveRuntime's Yoga and React Native's Yoga occuring when using static linkage. I thought namespacing Yoga in RiveRuntime might help, what do you think? |
As a workaround, downgrading to |
Its works on the emulator , but crashes in production |
|
Same with: {
"expo": "~52.0.0-preview.19",
"react-native": "0.76.1",
"rive-react-native": "^8.0.0"
} |
This should be resolved with 8.2.0. Please let me know if it doesn't work for you and we'll reopen this issue. Troubleshooting
|
I have a repo containing a minimal repro here: https://github.com/leemhenson/rive-firebase-yoga-issue For me, it still fails in exactly the same way as shown in the original screenshot above. You can try it yourself with:
It's unclear to me from previous discussions on this topic whether we are now expected to modify our
In my repro I have included a custom expo plugin in my app.json which does, but whether it's in the plugins list or not makes no difference to the outcome. |
This pull request addresses the following GitHub issues and more: - [rive-ios #345](rive-app/rive-ios#345) - [rive-react-native #268](rive-app/rive-react-native#268) Thanks to some help from @luigi-rosso, we discovered that the iOS runtime build scripts were _not_ including the Yoga renames, causing a collision when some frameworks were statically linked in React Native environments. This has been tested locally, and works, but the real test will be the public. Diffs= 437688c18e Add yoga renames to non-v2 lua build scripts (#8693) Co-authored-by: David Skuza <[email protected]>
This pull request addresses the following GitHub issues and more: - [rive-ios #345](#345) - [rive-react-native #268](rive-app/rive-react-native#268) Thanks to some help from @luigi-rosso, we discovered that the iOS runtime build scripts were _not_ including the Yoga renames, causing a collision when some frameworks were statically linked in React Native environments. This has been tested locally, and works, but the real test will be the public. Diffs= 437688c18e Add yoga renames to non-v2 lua build scripts (#8693)
This pull request addresses the following GitHub issues and more: - [rive-ios #345](rive-app/rive-ios#345) - [rive-react-native #268](rive-app/rive-react-native#268) Thanks to some help from @luigi-rosso, we discovered that the iOS runtime build scripts were _not_ including the Yoga renames, causing a collision when some frameworks were statically linked in React Native environments. This has been tested locally, and works, but the real test will be the public. Diffs= 437688c18e Add yoga renames to non-v2 lua build scripts (#8693)
This pull request addresses the following GitHub issues and more: - [rive-ios #345](rive-app/rive-ios#345) - [rive-react-native #268](rive-app/rive-react-native#268) Thanks to some help from @luigi-rosso, we discovered that the iOS runtime build scripts were _not_ including the Yoga renames, causing a collision when some frameworks were statically linked in React Native environments. This has been tested locally, and works, but the real test will be the public. Diffs= 437688c18e Add yoga renames to non-v2 lua build scripts (#8693)
This pull request addresses the following GitHub issues and more: - [rive-ios #345](rive-app/rive-ios#345) - [rive-react-native #268](rive-app/rive-react-native#268) Thanks to some help from @luigi-rosso, we discovered that the iOS runtime build scripts were _not_ including the Yoga renames, causing a collision when some frameworks were statically linked in React Native environments. This has been tested locally, and works, but the real test will be the public. Diffs= 437688c18e Add yoga renames to non-v2 lua build scripts (#8693)
This pull request addresses the following GitHub issues and more: - [rive-ios #345](rive-app/rive-ios#345) - [rive-react-native #268](rive-app/rive-react-native#268) Thanks to some help from @luigi-rosso, we discovered that the iOS runtime build scripts were _not_ including the Yoga renames, causing a collision when some frameworks were statically linked in React Native environments. This has been tested locally, and works, but the real test will be the public. Diffs= 437688c18e Add yoga renames to non-v2 lua build scripts (#8693)
This pull request addresses the following GitHub issues and more: - [rive-ios #345](rive-app/rive-ios#345) - [rive-react-native #268](rive-app/rive-react-native#268) Thanks to some help from @luigi-rosso, we discovered that the iOS runtime build scripts were _not_ including the Yoga renames, causing a collision when some frameworks were statically linked in React Native environments. This has been tested locally, and works, but the real test will be the public. Diffs= 437688c18e Add yoga renames to non-v2 lua build scripts (#8693)
Sorry, I was wrong about it being fixed in 8.2.0. I just pushed the button to release 8.3. @leemhenson It sounds like it's working for you now? Please let me know if you run into any issues with this. |
App crashes on IOS , works fine on Android for RN = 0.75.4
There may be some error in the package itself , as I even commented out all the import statements to check if this issue is replicated , but the issue still lies
The text was updated successfully, but these errors were encountered: