only reset state change on new frame

Duo reported they are not getting values updated correctly. Not sure if this is the (only) reason, but since we're resetting the state change on advance, if the state machine advances a second time in the same frame, it will reset its change status and could, down the line, not fire the state change notification. This PR makes sure we only reset the state change if it's advancing on a new frame Diffs= 88d24b0cd4 only reset state change on new frame (#8863) Co-authored-by: hernan <[email protected]>
rive-app · Jan 15, 2025 · 45e07d1 · 45e07d1
1 parent b08f843
commit 45e07d1
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/.rive_head b/.rive_head
@@ -1 +1 @@
-ac230e44d00b42527bc774b45b63d1b81a0c8705
+88d24b0cd44f46adc1ba0965689d16f6e1429693
diff --git a/src/animation/state_machine_instance.cpp b/src/animation/state_machine_instance.cpp
@@ -96,9 +96,12 @@ class StateMachineLayerInstance
         }
     }
 
-    bool advance(float seconds)
+    bool advance(float seconds, bool newFrame)
     {
-        m_stateMachineChangedOnAdvance = false;
+        if (newFrame)
+        {
+            m_stateMachineChangedOnAdvance = false;
+        }
         m_currentState->advance(seconds, m_stateMachineInstance);
         updateMix(seconds);
 
@@ -1542,7 +1545,7 @@ bool StateMachineInstance::advance(float seconds, bool newFrame)
     }
     for (size_t i = 0; i < m_layerCount; i++)
     {
-        if (m_layers[i].advance(seconds))
+        if (m_layers[i].advance(seconds, newFrame))
         {
             m_needsAdvance = true;
         }
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		ac230e44d00b42527bc774b45b63d1b81a0c8705
		88d24b0cd44f46adc1ba0965689d16f6e1429693