Fix layout animation repeat

This fixes a bug with layout animation (**editor only**): If a layout's bounds change while it is currently performing a layout animation, sometimes it will repeat the same animation after the first animation has completed. This was particularly evident when using spring interpolation. The root cause was an incorrect comparison (using == rather than the implemented equals() function) between the target layout bounds and the current animated bounds. In addition, this PR fixes an inconsistency between runtime layout animation and editor. Editor was previously restricting animation to relative layouts only, now we allow relative and absolute layout animations. Diffs= 61e927c9cf Fix layout animation repeat (#8875) Co-authored-by: Philip Chung <[email protected]>
rive-app · Jan 16, 2025 · 1ae9e50 · 1ae9e50
1 parent aadcd44
commit 1ae9e50
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/.rive_head b/.rive_head
@@ -1 +1 @@
-5b9b388fe9a3874a4c6a3f81dff310c9091198c1
+61e927c9cff9d2e5c86842ff4ea493bd6916d76a
diff --git a/src/layout_component.cpp b/src/layout_component.cpp
@@ -927,8 +927,7 @@ bool LayoutComponent::animates()
     {
         return false;
     }
-    return m_style->positionType() == YGPositionType::YGPositionTypeRelative &&
-           m_style->animationStyle() != LayoutAnimationStyle::none &&
+    return m_style->animationStyle() != LayoutAnimationStyle::none &&
            interpolation() != LayoutStyleInterpolation::hold &&
            interpolationTime() > 0;
 }
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		5b9b388fe9a3874a4c6a3f81dff310c9091198c1
		61e927c9cff9d2e5c86842ff4ea493bd6916d76a