Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trainerproc: Parse line markers #5122

Merged
merged 1 commit into from
Aug 8, 2024
Merged

trainerproc: Parse line markers #5122

merged 1 commit into from
Aug 8, 2024

Conversation

mrgriffin
Copy link
Collaborator

trainerproc did not handle line markers, and this meant that the #lines it generated to point compile errors at the .party file were off-by-lots due to the comments at the top of trainers.party.

Closes #5121

@mrgriffin mrgriffin added the bugfix Bugfixes label Aug 8, 2024
@Bassoonian Bassoonian added the category: battle-mechanic Pertains to battle mechanics label Aug 8, 2024
hedara90
hedara90 approved these changes Aug 8, 2024
View reviewed changes
Copy link
Collaborator

@hedara90 hedara90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, nothing immediately stood out.
Shasum matches before and after this PR, so it didn't seem to change anything it shouldn't.

@hedara90 hedara90 merged commit a5e0738 into rh-hideout:master Aug 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedara90 hedara90 hedara90 approved these changes

Assignees
No one assigned
Labels
bugfix Bugfixes category: battle-mechanic Pertains to battle mechanics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Errors in src/data/trainers.party point to incorrect lines for file.
3 participants
@mrgriffin @hedara90 @Bassoonian