Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors in src/data/trainers.party point to incorrect lines for file. #5121

Closed
SarnPoke opened this issue Aug 8, 2024 · 0 comments · Fixed by #5122
Closed

Errors in src/data/trainers.party point to incorrect lines for file. #5121

SarnPoke opened this issue Aug 8, 2024 · 0 comments · Fixed by #5122
Labels
bug Bug status: unconfirmed This bug has not been reproduced yet

Comments

@SarnPoke
Copy link

SarnPoke commented Aug 8, 2024

Description

I was made aware of this problem after @mrgriffin explained that at one point the error handling had worked fine for this file.
image

Basically, whenever a mistake is made in src/data/trainers.party, the resulting error when building will say that there's a problem on line X in src/data/trainers.party, when in reality there's a problem on line X in src/data/trainers.h leading to ghosthunting in src/data/trainers.party for an error that in that file is on a completely different line.

The actual problem in the case of the example image above was on line 14898 and not 14833. It was only on line 14833 in the generated src/data/trainers.h.

To reproduce:
Just make a mistake in src/data/trainers.party.

@mrgriffin Suggests that a possible solution to the issue would be to remove the comments at the top of src/data/trainers.party.

Version

1.9.0 (Latest release)

Upcoming/master Version

No response

Discord contact info

sarnnn

@SarnPoke SarnPoke added bug Bug status: unconfirmed This bug has not been reproduced yet labels Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug status: unconfirmed This bug has not been reproduced yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant