Fix some vanilla names that fit in the battle UI incorrectly using a narrow font #4979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is used to calculate which font to use for the species name in the health box
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update width for AddTextPrinterAndCreateWindowOnHealthboxToFit which is used to calculate which font to use for the species name in the health box from 54 -> 55
Images
Before fix (note the font for Charmander's name):
After fix:
Issue(s) that this PR fixes
Fixes #4712
People who collaborated with me in this PR
@mrgriffin thank you for answering my questions!
Discord contact info
iriv24