Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some vanilla names that fit in the battle UI incorrectly use a narrow font #4712

Closed
Sneed69 opened this issue Jun 3, 2024 · 3 comments
Closed
Labels
bug Bug status: unconfirmed This bug has not been reproduced yet
Milestone

Comments

@Sneed69
Copy link

Sneed69 commented Jun 3, 2024

Description

image

Version

upcoming (Edge)

Upcoming/master Version

No response

Discord contact info

duke5614

@Sneed69 Sneed69 added bug Bug status: unconfirmed This bug has not been reproduced yet labels Jun 3, 2024
@Sneed69 Sneed69 changed the title Vanilla names that fit in the battle UI incorrectly use a narrow font Some vanilla names that fit in the battle UI incorrectly use a narrow font Jun 3, 2024
@AsparagusEduardo AsparagusEduardo added this to the 1.9.0 milestone Jun 3, 2024
@pkmnsnfrn
Copy link
Collaborator

@AsparagusEduardo I agree this isn't GREAT, but I don't think its simple OR degrading the experience. Do you truly believe this should block 1.9.0.?

@AsparagusEduardo
Copy link
Collaborator

AsparagusEduardo commented Jul 15, 2024

@AsparagusEduardo I agree this isn't GREAT, but I don't think its simple OR degrading the experience. Do you truly believe this should block 1.9.0.?

I can't imagine this fix would be too hard to implement before 1.9 (famous last words ^^;)

@mrgriffin
Copy link
Collaborator

It may be possible to add some tests which check all the vanilla names fit in all the spaces? Those tests would look similar to the existing ones (in test/text.c), but use the default font for the particular UIs instead of the narrowest ones and only test the vanilla IDs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug status: unconfirmed This bug has not been reproduced yet
Projects
None yet
Development

No branches or pull requests

4 participants