Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug menu tweaks #4025

Merged

Conversation

AsparagusEduardo
Copy link
Collaborator

@AsparagusEduardo AsparagusEduardo commented Jan 19, 2024

Description

"Access PC" is by far the most used function in that submenu, so it just makes sense to me to have it as the first option.

EDIT: also fixed item get music cutting out by using a shorter jingle + removed redundant "Give all TMs" option.

Images

image
Look how quick you can go to Access PC 👀
mGBA_ZItQxAzTvE

Issue(s) that this PR fixes

Fixes #3225

Discord contact info

AsparagusEduardo

@AsparagusEduardo AsparagusEduardo changed the title Moved Access PC to the first option of the PC/Bag debug submenu Debug menu tweaks Jan 19, 2024
@AlexOn1ine
Copy link
Collaborator

AlexOn1ine commented Jan 19, 2024

I tried to remove the second Give all TMs option in #3388 once but Egg was against it. I'm fine with either so you'll have to decide. Bringing it up just in case.

@AlexOn1ine
Copy link
Collaborator

I tried to remove the second Give all TMs option in #3388 once but Egg was against it. I'm fine with either so you'll have to decide. Bringing it up just in case.

I just merge it. Egg and Edu can fight over it 😄

@AlexOn1ine AlexOn1ine merged commit 6857497 into rh-hideout:upcoming Jan 19, 2024
1 check passed
@AsparagusEduardo AsparagusEduardo deleted the _RHH/pr/upcoming/PCdebug branch January 19, 2024 21:01
@AsparagusEduardo
Copy link
Collaborator Author

I just merge it. Egg and Edu can fight over it 😄

Bringing my fighting gloves lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants