Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Salt Cure visual bug if mon fainted by direct attack #3388

Merged
merged 4 commits into from
Oct 9, 2023

Conversation

AlexOn1ine
Copy link
Collaborator

@AlexOn1ine AlexOn1ine commented Oct 7, 2023

Fixes #3386

Before:
salt_cure_bug
After:
salt_cure

@DizzyEggg
Copy link
Collaborator

All good, it's only missing a test.

Copy link
Collaborator

@DizzyEggg DizzyEggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests

@AlexOn1ine
Copy link
Collaborator Author

Test added.

@DizzyEggg
Copy link
Collaborator

Salt Cure is fine, but not sure about the other one. Is it actually bad that there are two options that do the same thing? I assume giving TMs is something that's often done when debugging, so it's easier for users to quickly locate this given it's in 2 places. What do others think about it?

@AlexOn1ine
Copy link
Collaborator Author

AlexOn1ine commented Oct 9, 2023

Salt Cure is fine, but not sure about the other one. Is it actually bad that there are two options that do the same thing? I assume giving TMs is something that's often done when debugging, so it's easier for users to quickly locate this given it's in 2 places. What do others think about it?

Yeah, I don't mind reverting the change back to normal. I just did it because it was an open issue and relatively easy to fix. And I do agree that it doesn't hurt having both options.

@AlexOn1ine
Copy link
Collaborator Author

Reverted the removal of the debug TM/HM duplicate case

@DizzyEggg DizzyEggg merged commit 36174f1 into rh-hideout:master Oct 9, 2023
1 check passed
@AlexOn1ine AlexOn1ine deleted the salt_cure branch October 9, 2023 21:42
@AlexOn1ine AlexOn1ine mentioned this pull request Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Salt Cure kill Visual Bug
2 participants